Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add ignoreNullValues for AWS CloudWatch Scaler (#5635)
* add errorWhenMetricValueEmpty Signed-off-by: Rob Pickerill <[email protected]> * fix golangci-lint Signed-off-by: Rob Pickerill <[email protected]> * improve error message for empty results Signed-off-by: Rob Pickerill <[email protected]> * add error when empty metric values to changelog Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * use getParameterFromConfigV2 to read config for errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * add e2e for error state for cw, and improve e2e for min values for cw Signed-off-by: Rob Pickerill <[email protected]> * remove erroneous print statement Signed-off-by: Rob Pickerill <[email protected]> * remove unused vars Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * move towards shared package for e2e aws Signed-off-by: Rob Pickerill <[email protected]> * minMetricValue optionality based on ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * fail fast Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Apply suggestions from code review Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fail fast Signed-off-by: Rob Pickerill <[email protected]> * fix broken new line Signed-off-by: Rob Pickerill <[email protected]> * fix broken new lines Signed-off-by: Rob Pickerill <[email protected]> * assert no scaling changes in e2e, and set false for required in minMetricValue Signed-off-by: robpickerill <[email protected]> * fix ci checks Signed-off-by: robpickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go fix invalid check Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fix merge conflicts Signed-off-by: robpickerill <[email protected]> * fix e2e package names Signed-off-by: robpickerill <[email protected]> --------- Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: robpickerill <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]>
- Loading branch information