Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mongodb): escape username and password #3989

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 8, 2022

Signed-off-by: Jorge Turrado [email protected]

If either the username or password contains a character in the set :/?#[]@ , it must be percent-encoded or the scaler will fail.

Checklist

  • Tests have been added
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #3992

@JorTurFer JorTurFer requested a review from a team as a code owner December 8, 2022 21:36
@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 8, 2022

/run-e2e mongo*
Update: You can check the progress here

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 9, 2022

/run-e2e mongo*
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 3e40fc6 into kedacore:main Dec 9, 2022
@JorTurFer JorTurFer deleted the mongo-encode branch December 9, 2022 10:42
@JorTurFer JorTurFer mentioned this pull request Jan 17, 2023
1 task
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 18, 2023
@pedro-stanaka pedro-stanaka mentioned this pull request Jan 18, 2023
7 tasks
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 18, 2023
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 19, 2023
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 19, 2023
JorTurFer added a commit that referenced this pull request Jan 19, 2023
* fix: CVE-2022-3172 (#3693)

Signed-off-by: Pedro Tanaka <[email protected]>

* fix: Respect optional parameter inside envs for ScaledJobs (#3694)

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix(prometheus scaler): Detect Inf before casting float to int (#3762)

* fix(prometheus scaler): Detect Inf before casting float to int

Signed-off-by: Jorge Turrado <[email protected]>

* Improve the log message

Signed-off-by: Jorge Turrado <[email protected]>

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix(nats-jetstream): correctly count messages that should be redelivered (waiting for ack) towards keda value (#3809)

* fix: keda now include the messages that should be retried in the count of pending messages used for scaling

Signed-off-by: Antoine Laffargue <[email protected]>

* chore: update changelog

Signed-off-by: Antoine Laffargue <[email protected]>

Signed-off-by: Antoine Laffargue <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* NewRelic scaler crashes on logging (#3946)

Signed-off-by: Laszlo Kishalmi <[email protected]>

Signed-off-by: Laszlo Kishalmi <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* Fix stackdriver client returning 0 for metric types of double (#3788)

* Update stackdriver client to handle metrics of value type double

Signed-off-by: Eric Takemoto <[email protected]>

* move change log note to below general

Signed-off-by: Eric Takemoto <[email protected]>

* parse activation value as float64

Signed-off-by: Eric Takemoto <[email protected]>

* change target value to float64 for GCP pub/sub and stackdriver

Signed-off-by: Eric Takemoto <[email protected]>

Signed-off-by: Eric Takemoto <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing conflicts after cherry-pick

Signed-off-by: Pedro Tanaka <[email protected]>

* fix: Close is called twice on PushScaler's deletion (#3599)

Signed-off-by: ytz <[email protected]>
Signed-off-by: taenyang <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix/datadog-scaler-null-last-point (#3954)

Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix(mongodb): escape username and password (#3989)

Fixes #3992

Signed-off-by: Pedro Tanaka <[email protected]>

* Hacking generated files to version CI expects

Signed-off-by: Pedro Tanaka <[email protected]>

* Updating aws-sdk and golang packages to fix CVEs

Signed-off-by: Pedro Tanaka <[email protected]>

* Updating golang/text package to fix CVE

Signed-off-by: Pedro Tanaka <[email protected]>

* Using same version of aws sdk as in main

Signed-off-by: Pedro Tanaka <[email protected]>

Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Antoine Laffargue <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Laszlo Kishalmi <[email protected]>
Signed-off-by: Eric Takemoto <[email protected]>
Signed-off-by: ytz <[email protected]>
Signed-off-by: taenyang <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Antoine LAFFARGUE <[email protected]>
Co-authored-by: Laszlo Kishalmi <[email protected]>
Co-authored-by: Eric Takemoto <[email protected]>
Co-authored-by: taenyang <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB Scaler: Failures with given username/password contains :/?#[]@
2 participants