Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/datadog-scaler-null-last-point #3954

Merged
merged 16 commits into from
Dec 8, 2022
Merged

fix/datadog-scaler-null-last-point #3954

merged 16 commits into from
Dec 8, 2022

Conversation

dogzzdogzz
Copy link
Contributor

@dogzzdogzz dogzzdogzz commented Dec 5, 2022 •
edited
Loading

In issue 3906, we found out that the last data point of some specific query always returns null, this fix is to find out the last data point which is not null instead of validating the last data point only

Checklist

Fixes #3906

@dogzzdogzz dogzzdogzz requested a review from a team as a code owner December 5, 2022 06:46
@dogzzdogzz
check point's length
0c5a9b0 
Signed-off-by: Tony Lee <[email protected]>
zroubalik
zroubalik requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please unit test for this? Should be trivial, there are some existig tests already, thanks!

https://github.com/kedacore/keda/blob/main/pkg/scalers/datadog_scaler_test.go#L55-L86

CHANGELOG.md Outdated Show resolved Hide resolved
@dogzzdogzz
Copy link
Contributor Author

@zroubalik unit test added, could you review it ?

@dogzzdogzz
remove redudant code
8fb0d68 
Signed-off-by: Tony Lee <[email protected]>
tonylee-shopback and others added 3 commits December 8, 2022 09:44
@tonylee-shopback
Merge branch 'main' into fix/datadog-scaler-null-last-point
36979e4 
Signed-off-by: Tony Lee <[email protected]>
@dogzzdogzz
rename the iterator
6ddddcd 
Signed-off-by: Tony Lee <[email protected]>
@dogzzdogzz
feature/datadog-scaler-timeWindowOffset-and-timeWindowOffset (#1)
f862d0f 
* feature/datadog-scaler-timeWindowOffset-and-timeWindowOffset

Signed-off-by: Tony Lee <[email protected]>

* fix bug

Signed-off-by: Tony Lee <[email protected]>

Signed-off-by: Tony Lee <[email protected]>
@dogzzdogzz dogzzdogzz requested review from JorTurFer and zroubalik and removed request for zroubalik and JorTurFer December 8, 2022 07:30
@dogzzdogzz
remove comment
392afae 
Signed-off-by: Tony Lee <[email protected]>
@dogzzdogzz dogzzdogzz mentioned this pull request Dec 8, 2022
Closed
@zroubalik
Copy link
Member

@dogzzdogzz could you please fix the Static Check?

@dogzzdogzz
fix static check err
1559e6d 
Signed-off-by: Tony Lee <[email protected]>
@zroubalik
Copy link
Member

@dogzzdogzz the problem is still there :(

@zroubalik
Copy link
Member

@dogzzdogzz you can probably add exception for this check here: https://github.com/kedacore/keda/blob/main/.golangci.yml#L63

@zroubalik
Copy link
Member

zroubalik commented Dec 8, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@dogzzdogzz
Copy link
Contributor Author

static check passed, thanks for the suggestion

@zroubalik zroubalik merged commit 455eab3 into kedacore:main Dec 8, 2022
@JorTurFer JorTurFer mentioned this pull request Jan 17, 2023
Closed
1 task
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 18, 2023
@dogzzdogzz @tonylee-shopback
@zroubalik @pedro-stanaka
fix/datadog-scaler-null-last-point (kedacore#3954)
b822e30 
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
@pedro-stanaka pedro-stanaka mentioned this pull request Jan 18, 2023
Merged
7 tasks
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 18, 2023
@dogzzdogzz @tonylee-shopback
@zroubalik @pedro-stanaka
fix/datadog-scaler-null-last-point (kedacore#3954)
b4ae488 
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 19, 2023
@dogzzdogzz @tonylee-shopback
@zroubalik @pedro-stanaka
fix/datadog-scaler-null-last-point (kedacore#3954)
9d17c13 
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka pushed a commit to pedro-stanaka/keda that referenced this pull request Jan 19, 2023
@dogzzdogzz @tonylee-shopback
@zroubalik @pedro-stanaka
fix/datadog-scaler-null-last-point (kedacore#3954)
5c55da6 
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
JorTurFer added a commit that referenced this pull request Jan 19, 2023
@pedro-stanaka @JorTurFer
@toniopelo @lkishalmi @octothorped @dogzzdogzz @tonylee-shopback @zroubalik
Backport fixes to release 2.8 (#4135)
e0ba57d 
* fix: CVE-2022-3172 (#3693)

Signed-off-by: Pedro Tanaka <[email protected]>

* fix: Respect optional parameter inside envs for ScaledJobs (#3694)

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix(prometheus scaler): Detect Inf before casting float to int (#3762)

* fix(prometheus scaler): Detect Inf before casting float to int

Signed-off-by: Jorge Turrado <[email protected]>

* Improve the log message

Signed-off-by: Jorge Turrado <[email protected]>

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix(nats-jetstream): correctly count messages that should be redelivered (waiting for ack) towards keda value (#3809)

* fix: keda now include the messages that should be retried in the count of pending messages used for scaling

Signed-off-by: Antoine Laffargue <[email protected]>

* chore: update changelog

Signed-off-by: Antoine Laffargue <[email protected]>

Signed-off-by: Antoine Laffargue <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* NewRelic scaler crashes on logging (#3946)

Signed-off-by: Laszlo Kishalmi <[email protected]>

Signed-off-by: Laszlo Kishalmi <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* Fix stackdriver client returning 0 for metric types of double (#3788)

* Update stackdriver client to handle metrics of value type double

Signed-off-by: Eric Takemoto <[email protected]>

* move change log note to below general

Signed-off-by: Eric Takemoto <[email protected]>

* parse activation value as float64

Signed-off-by: Eric Takemoto <[email protected]>

* change target value to float64 for GCP pub/sub and stackdriver

Signed-off-by: Eric Takemoto <[email protected]>

Signed-off-by: Eric Takemoto <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing conflicts after cherry-pick

Signed-off-by: Pedro Tanaka <[email protected]>

* fix: Close is called twice on PushScaler's deletion (#3599)

Signed-off-by: ytz <[email protected]>
Signed-off-by: taenyang <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix/datadog-scaler-null-last-point (#3954)

Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>

* fix(mongodb): escape username and password (#3989)

Fixes #3992

Signed-off-by: Pedro Tanaka <[email protected]>

* Hacking generated files to version CI expects

Signed-off-by: Pedro Tanaka <[email protected]>

* Updating aws-sdk and golang packages to fix CVEs

Signed-off-by: Pedro Tanaka <[email protected]>

* Updating golang/text package to fix CVE

Signed-off-by: Pedro Tanaka <[email protected]>

* Using same version of aws sdk as in main

Signed-off-by: Pedro Tanaka <[email protected]>

Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Antoine Laffargue <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Laszlo Kishalmi <[email protected]>
Signed-off-by: Eric Takemoto <[email protected]>
Signed-off-by: ytz <[email protected]>
Signed-off-by: taenyang <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Tony Lee <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Antoine LAFFARGUE <[email protected]>
Co-authored-by: Laszlo Kishalmi <[email protected]>
Co-authored-by: Eric Takemoto <[email protected]>
Co-authored-by: taenyang <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Tony Lee <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Datadog scaler] Scaler returns fillValue if the last data point of query is null
4 participants
@dogzzdogzz @zroubalik @JorTurFer @tonylee-shopback