Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.8.2 #4132

Closed
1 task done
JorTurFer opened this issue Jan 17, 2023 · 10 comments
Closed
1 task done

Release v2.8.2 #4132

JorTurFer opened this issue Jan 17, 2023 · 10 comments
Assignees
Labels
governance release-management All issues related to how we release

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Jan 17, 2023

Due to the reduced k8s versions supported for KEDA v2.9, we have decided to do an exceptional release for v2.8, back porting all the fixes and CVEs we have already solved.

This issue will track all the needed PR for being back ported:

Merged at Number SHA Back ported?
2022-09-27T06:11:08Z #3693 4c19b38 Yes
2022-10-10T11:13:44Z #3694 322ff42 Yes
2022-11-04T14:58:08Z #3762 7af0953 Yes
2022-11-09T07:51:30Z #3809 971ab94 Yes
2022-12-02T08:06:05Z #3946 a489ca7 Yes
2022-12-05T17:22:48Z #3788 d5f3349 Yes
2022-12-07T14:20:21Z #3599 5953f7b Yes
2022-12-08T16:47:41Z #3954 455eab3 Yes
2022-12-09T10:42:37Z #3989 3e40fc6 Yes
2022-12-15T09:38:52Z #4012 06f6f7d WONT FIX
2022-12-16T10:18:26Z #4006 6c49e26 WONT FIX
2022-12-24T11:56:14Z #4039 b7607fc WONT FIX

Additionally, we need to solve this issue during the release, fixing the v2.8 helm chart

@pedro-stanaka
Copy link
Contributor

Is it okay if we backport all of those in one PR? I started cherrypicking into one branch, but I am wondering if it is okay.

@pedro-stanaka
Copy link
Contributor

pedro-stanaka commented Jan 18, 2023

Merged at Number SHA Back ported?
2022-09-27T06:11:08Z #3693 4c19b38 Yes
2022-10-10T11:13:44Z #3694 322ff42 Yes
2022-11-04T14:58:08Z #3762 7af0953 Yes
2022-11-09T07:51:30Z #3809 971ab94 Yes
2022-12-02T08:06:05Z #3946 a489ca7 Yes
2022-12-05T17:22:48Z #3788 d5f3349 Yes
2022-12-07T14:20:21Z #3599 5953f7b Yes
2022-12-08T16:47:41Z #3954 455eab3 Yes
2022-12-09T10:42:37Z #3989 3e40fc6 Yes
2022-12-15T09:38:52Z #4012 06f6f7d WONT FIX
2022-12-16T10:18:26Z #4006 6c49e26 WONT FIX
2022-12-24T11:56:14Z #4039 b7607fc WONT FIX

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 18, 2023

I think it's not a problem @kedacore/keda-core-contributors ?

@pedro-stanaka
Copy link
Contributor

I opened #4135 where I am back porting all PRs except the three last ones from the table above. #4012 is specially tricky because it is using a lot of new code from APIs that I suppose was refactored. So since I am not 100% familiar with the code base I feel not safe to cherrypick. I will work on the issues I see already in #4135 and will try to make CI work. If you or another maintainer could help, would be nice. Thx.

@JorTurFer
Copy link
Member Author

No worries, if you have cherry-picked the others, we can fix those 3. You have already helped a lot, with the amount of commits you have backported 🙇

@zroubalik
Copy link
Member

Hi, #4012 is not needed, the problem it is fixing has been introduced in 2.9.0.

I also think that we don't have to do #4006 - it is rather a change in funcitonality

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 18, 2023

Hi, #4012 is not needed, the problem it is fixing has been introduced in 2.9.0.

perfect!

I also think that we don't have to do #4006 - it is rather a change in funcitonality

It is indeed, but it's for solving a critical security issue (this was detected during the audit), IMO we should back port it

@zroubalik
Copy link
Member

okay, let's proceed with #4006 in a separate PR once this one is merged

@JorTurFer
Copy link
Member Author

Yeah, I'll back port that PR, I did the original PR so I hope it'll be easy :)

@tomkerkhove tomkerkhove changed the title Back ports for incoming release v2.8.2 Release v2.8.2 Jan 18, 2023
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 19, 2023

KEDA v2.8.2 has been released 🥳 🥳 🥳
@pedro-stanaka , you can pull the chart v2.8.3 when you want (and let's us know if there is any error with it)

BTW, thanks a ton for your awesome help ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
governance release-management All issues related to how we release
Projects
Archived in project
Development

No branches or pull requests

4 participants