Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go tests for GCP stackdriver and pubsub #3384

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Add go tests for GCP stackdriver and pubsub #3384

merged 7 commits into from
Jul 19, 2022

Conversation

RamCohen
Copy link
Contributor

@RamCohen RamCohen commented Jul 17, 2022 •
edited by zroubalik
Loading

Signed-off-by: Ram Cohen [email protected]

Add go tests for GCP stackdriver and pubsub

Fixes #3174
Fixes #3234

Relates to #2737

@RamCohen RamCohen requested a review from a team as a code owner July 17, 2022 07:23
@RamCohen
Id -> ID naming
f077958 
Signed-off-by: Ram Cohen <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Jul 18, 2022 •
edited by github-actions bot
Loading

/run-e2e gcp*
Update: You can check the progress here

@RamCohen
Fix Id->ID in yaml
ed8b2e5 
Signed-off-by: Ram Cohen <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Jul 18, 2022 •
edited by github-actions bot
Loading

/run-e2e gcp*
Update: You can check the progress here

@JorTurFer
Copy link
Member

@RamCohen could you please add activation property as part of this PR, we have started to adding this existing scalers as you can see in these PRs:
#3358
#3360

@zroubalik
Copy link
Member

@RamCohen could you please add activation property as part of this PR, we have started to adding this existing scalers as you can see in these PRs: #3358 #3360

Or this could be contributed as a separate PR if you prefer to do so.

zroubalik
zroubalik reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, please use this waiter function, as the old one will be removed in: #3377

tests/scalers_go/gcp_stackdriver/gcp_stackdriver_test.go Outdated Show resolved Hide resolved
tests/scalers_go/gcp_stackdriver/gcp_stackdriver_test.go Outdated Show resolved Hide resolved
@RamCohen
Copy link
Contributor Author

@RamCohen could you please add activation property as part of this PR, we have started to adding this existing scalers as you can see in these PRs: #3358 #3360

Or this could be contributed as a separate PR if you prefer to do so.

I'd rather do it in a separate PR as it relates to the scaler functionality

@zroubalik
Copy link
Member

zroubalik commented Jul 18, 2022 •
edited by github-actions bot
Loading

/run-e2e gcp*
Update: You can check the progress here

@RamCohen
increase idle wait time
7330c3d 
Signed-off-by: Ram Cohen <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Jul 19, 2022 •
edited by github-actions bot
Loading

/run-e2e gcp*
Update: You can check the progress here

@RamCohen
Merge
852f87c 
Signed-off-by: Ram Cohen <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Jul 19, 2022 •
edited by github-actions bot
Loading

/run-e2e gcp*
Update: You can check the progress here

@RamCohen
Fix bad merge
3eb8ba9 
Signed-off-by: Ram Cohen <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Jul 19, 2022 •
edited by github-actions bot
Loading

/run-e2e gcp*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@zroubalik zroubalik merged commit c57413a into kedacore:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for GCP StackDriver to Go Migrate e2e test for Google Cloud Pub/Sub scaler to Go.
3 participants
@RamCohen @zroubalik @JorTurFer