Migrate e2e tests to Go

[tomkerkhove]

Migrate e2e tests to Go instead of typescript to standardize one one language.

We should use a phased approach where we migrate one scaler and run the new approach next to the current one to verify the setup.

New scalers should be in Go and then gradually migrate old tests over.

• Migrate e2e test for ActiveMQ to Go #3224
• Migrate e2e test for Artemis to Go #3225
• Migrate e2e test for AWS CloudWatch Expression to Go #3226
• Migrate e2e test for AWS Cloudwatch scaler to Go #3173
• Migrate e2e test for AWS DynamoDB to Go #3227
• Migrate e2e test for AWS Kinesis Stream scaler to Go. #3171
• Migrate e2e test for AWS SQS Queue scaler to Go. #3172
• Migrate e2e test for Azure Application Insights to Go #3228
• Migrate e2e test for Azure Blob Storage to Go #3229
• Migrate e2e test for Azure Data Explorer to Go #3257
• Migrate e2e test for Azure Log Analytics to Go #3258
• Migrate e2e test for Azure Pipelines to Go #3259
• Migrate e2e test for Azure Storage Queues scaler to Go #3223
• Migrate e2e test for Azure Service Bus to Go #3230
• Migrate e2e test for Cassandra to Go #3231
• Migrate e2e test for Cron to Go. #3217
• Migrate e2e test for CPU scaler to Go. #3169
• Migrate e2e test for Datadog to Go #3232
• Migrate e2e test for Elasticsearch to Go #3233
• Migrate e2e test for external scaler to Go. #3175
• Migrate e2e test for Google Cloud Pub/Sub scaler to Go. #3174
• Migrate e2e test for GCP StackDriver to Go #3234
• Migrate e2e test for GCP Storage to Go #3235
• Migrate e2e test for Graphite to Go #3236
• Migrate e2e test for InfluxDB to Go #3237
• Migrate e2e test for Kafka to Go #3238
• Migrate e2e test for Kubernetes Workload to Go #3239
• Migrate e2e test for memory scaler to Go. #3170
• Migrate e2e test for Metrics API to Go #3240
• Migrate e2e test for MongoDB to Go #3241
• Migrate e2e test for MSSQL to Go #3242
• Migrate e2e test for MySQL to Go #3243
• Migrate e2e test for NewRelic to Go #3244
• Migrate e2e test for OpenStack Swift to Go #3245
• Migrate e2e test for Hashicorp Vault to Go. #3176
• Migrate e2e test for PostgreSQL to Go #3246
• Migrate e2e test for PredictKube to Go #3247
• Migrate e2e test for Prometheus to Go #3248
• Migrate e2e test for RabbitMQ to Go #3249
• Migrate e2e test for Redis Cluster (Lists + Streams) to Go #3250
• Migrate e2e test for Redis (Lists + Streams) to Go #3251
• Migrate e2e test for Redis Sentinel (Lists + Streams) to Go #3252
• Migrate e2e test for Selenium Grid to Go #3253
• Migrate e2e test for Solace to Go #3254
• Migrate e2e test for Stan to Go #3256
• Migrate e2e test for /scale subresource in CRDs to Go #3260
• Migrate e2e test for Value metricType to Go  #3435
• Migrate internal e2e tests to use simple scaler #3436

[tomkerkhove]

Thoughts @kedacore/keda-core-contributors?

[JorTurFer]

There is not an icon to reflect how much I agree with this proposal 😁😁

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[v-shenoy]

Bumping this issue. I think this switch would be highly beneficial and work on it should get started. There's no need for a project that's written entirely in Go, to have its e2e tests written in TypeScript. The more we delay this, the tougher it's going to get with more scalers and their typescript tests being added.

[tomkerkhove]

💯, we just need to find somebody who wants to go through it 😅

[v-shenoy]

First of all, there's the discussion of which Go testing framework to be used, and with which assertion framework. Currently, there's a bit of inconsistency with some unit tests using testify/assert, while some are using another, while some are using manual comparisons with the default testing framework.

Once the decision is finalized, a little bit of work would also be required to bring existing tests to parity.

As for the e2e tests themselves, we should probably have an umbrella thread asking for Go tests similar to the one already existing, and start accepting new tests only in Go.

[v-shenoy]

@kedacore/keda-core-contributors I am willing to start this off with e2e tests for the Azure scalers. I was considering just using testify for its assertion framework and maybe suite, and nothing more.

[zroubalik]

@v-shenoy that would be great! Please sync with @JorTurFer.

It doesn't have to be over complex, but we should have some general library with wait/deploy/watch/log methods.

[JorTurFer]

I did some tries, but nothing really important, if you are willing to contribute with this, I'll not be who blocks you xD
My only concern/request is that please, use a tool/framework that can be debuggable please 🙏 .
Developing e2e test with npx ava printing logs is a pain

[v-shenoy]

I'll send a draft PR with one test tomorrow, for reference.

[tomkerkhove]

Thanks a ton @v-shenoy!

[tomkerkhove]

Please don't forget to update the contribution guide as well;

[v-shenoy]

Please don't forget to update the contribution guide as well;

tests/README has already been updated with basic guide about tests in Go.

[tomkerkhove]

I was thinking about https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#contributing-scalers but that just points to the above README so we are good to go.

Thanks.

[v-shenoy]

Halfway there, phew!

[tomkerkhove]

Nice progress on this!

[goku321]

I can take care of Redis related tests(if no one is working on them) once I'm done with NATS JetStream scaler

[JorTurFer]

Redis is almost done, I have the PR opened
😁

[JorTurFer]

@goku321 , do you know about Redis Stream in general? Could I ask if you could answer this?

[v-shenoy]

Took a while, but we got there :)

[tomkerkhove]

Congrats and thanks to everyone who has contributed to this! 🎉