Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce activationThreshold/minMetricValue for Datadog Scaler #3360

Merged
merged 8 commits into from
Jul 18, 2022
Merged

feat: Introduce activationThreshold/minMetricValue for Datadog Scaler #3360

merged 8 commits into from
Jul 18, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jul 13, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado [email protected]

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added

Fixes #3232

Related to #2800
Related to kedacore/keda-docs#812

@JorTurFer JorTurFer requested a review from a team as a code owner July 13, 2022 00:04
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 13, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 13, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 13, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Jul 13, 2022
Merged
1 task
@zroubalik zroubalik mentioned this pull request Jul 13, 2022
Merged
5 tasks
@zroubalik
Copy link
Member

zroubalik commented Jul 14, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 14, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 14, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 14, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer
feat: Introduce activationThreshold/minMetricValue for Datadog Scaler
5a2d767 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
remove old e2e test
61d580d 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Add env placeholder to .env
7dd57e2 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix style
5835864 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix style
658f88c 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer force-pushed the activation-threshold-datadog branch from 590741e to 81f3616 Compare July 15, 2022 08:50
@JorTurFer
update e2e test
9ea275a 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer force-pushed the activation-threshold-datadog branch from 81f3616 to 9ea275a Compare July 15, 2022 08:51
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 15, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 15, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Jul 18, 2022
Merged
Jorge Turrado added 2 commits July 18, 2022 13:26
fix typo and add unit test
c25be7d 
Signed-off-by: Jorge Turrado <[email protected]>
readd deleted row
6edbe1e 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 18, 2022 •
edited by github-actions bot
Loading

/run-e2e datadog*
Update: You can check the progress here

@zroubalik zroubalik merged commit 45b4b28 into kedacore:main Jul 18, 2022
@JorTurFer JorTurFer deleted the activation-threshold-datadog branch July 18, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for Datadog to Go
2 participants
@JorTurFer @zroubalik