fix: Added support for vault kv-v1 (#2645)

[chaunceyt]

Signed-off-by: Chauncey Thorn [email protected]

Adding support for HashiCorp Key-Value v1 secrets backend. Also fixed a typo in log output.

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Tests have been added
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Changelog has been updated and is aligned with our changelog requirements

Fixes #2645

[JorTurFer]

LGTM!
Thanks for the fix and the research you have done ❤️
Could you update the changelog?

[zroubalik]

Thanks, do you think you can add a simple unit test for this?

[chaunceyt]

I'll work to get the changelog update and unit test in. Hopefully I'll be able to get it done this weekend.

@zroubalik I was looking for the test for the v2 secret engine. Can you point me to that so I can extend that test?

Thanks

[zroubalik]

I'll work to get the changelog update and unit test in. Hopefully I'll be able to get it done this weekend.

@zroubalik I was looking for the test for the v2 secret engine. Can you point me to that so I can extend that test?

Thanks

Unfortunately there isn't any specific test for this :(

[zroubalik]

@chaunceyt we have added HashiCorp E2E tests, do you think you can extend them to cover kv-v1? #2849

[chaunceyt]

@zroubalik Yes following the pattern in tests/scalers/postgresql-hashicorp-vault.test.ts I can extend to cover kv-v1. This pattern seems less work that trying to add it to scale_resolvers_test.go

Thanks for pointing me to this.

[JorTurFer]

one thing @chaunceyt
Please take into account that if you create another test file, they can run in parallel sometimes. I said because I had errors installing 2 instances of vault in due to Clusterroles, maybe the parameters need to be updated in any way

[zroubalik]

@chaunceyt any update on thia please? We are going to release 2.7.0 soon (May 7). So would be great if we can include this as well.

[chaunceyt]

@zroubalik
Currently on vacation, will return beginning of the month and will work to get the test written and submitted. Sorry for the long delay been really busy.

[zroubalik]

@chaunceyt just FYI we plan to do the release May 5

[tomkerkhove]

@chaunceyt Any thought if we can close this PR soon? We are planning to release in 2 weeks.

[zroubalik]

@chaunceyt ping :)

[JorTurFer]

You will need to rebase your PR too

[chaunceyt]

Hi, sorry for lack of response and delay getting back to this. I am going to close the PR. I accidentally noticed the lack of v1 support using incorrect path for v2 setup. After fixing that the Vault integration works as desired without the change.

I'm going to speculate that very few if anyone is using v1 for Vault these days.

Thanks for the patience shown due to my lack of response.
Keep up the good work.