Add support for Hashicorp Vault KV engine V1 #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dangerousplay <[email protected]>
|
/run-e2e hashicorp* |
JorTurFer
approved these changes
Jan 22, 2023
zroubalik
approved these changes
Jan 23, 2023
Yeah, we should probably add a not on this into the docs. |
1 task
|
Sure, a pull request with a note about version 1 and 2 support was created kedacore/keda-docs#1051. I appreciate your review, have a nice day. |
sdomme
pushed a commit
to sdomme/keda
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Dangerousplay <[email protected]> Signed-off-by: Dangerousplay <[email protected]> Signed-off-by: Sergej Domme <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Hashicorp Vault secrets backend version 1. The altered code is the same from the pull request #2772, with an end-to-end test to validate the changes.
Checklist
Fixes #2645
Relates to #2772
Have a wonderful day,
Best regards.