Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hashicorp Vault secret provider e2e test #2849

Merged
merged 4 commits into from
Apr 1, 2022
Merged

Add Hashicorp Vault secret provider e2e test #2849

merged 4 commits into from
Apr 1, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Mar 30, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado [email protected]

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2842

@JorTurFer JorTurFer requested a review from a team as a code owner March 30, 2022 21:12
@JorTurFer
update changelog
6dd72b2 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
sort changelog
d4fdc40 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2022 •
edited by github-actions bot
Loading

/run-e2e hashicorp
Update: You can check the progres here

fix style3s
0184bb3 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 31, 2022 •
edited by github-actions bot
Loading

/run-e2e hashicorp
Update: You can check the progres here

@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 31, 2022 •
edited by github-actions bot
Loading

/run-e2e hashicorp
Update: You can check the progres here

zroubalik
zroubalik approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 0c318fe into kedacore:main Apr 1, 2022
@zroubalik zroubalik mentioned this pull request Apr 1, 2022
Closed
5 tasks
@JorTurFer JorTurFer deleted the add-hashicorp-e2e branch April 1, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2e test for Hashicorp Vault
2 participants
@JorTurFer @zroubalik