Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate e2e test for /scale subresource to Go. #3502

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Migrate e2e test for /scale subresource to Go. #3502

merged 1 commit into from
Aug 4, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Aug 4, 2022

Signed-off-by: Vighnesh Shenoy [email protected]

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added

Fixes #3260

Relates to #2737

@v-shenoy v-shenoy requested a review from a team as a code owner August 4, 2022 11:10
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Aug 4, 2022 •
edited by github-actions bot
Loading

/run-e2e subresource
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) August 4, 2022 13:32
@JorTurFer
Copy link
Member

JorTurFer commented Aug 4, 2022 •
edited by github-actions bot
Loading

/run-e2e subresource
Update: You can check the progress here

zroubalik
zroubalik approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks!

@JorTurFer JorTurFer merged commit 9b8fe76 into kedacore:main Aug 4, 2022
@v-shenoy v-shenoy deleted the subresource-scale branch August 4, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for /scale subresource in CRDs to Go
3 participants
@v-shenoy @JorTurFer @zroubalik