Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate e2e test for MongoDB to Go. #3380

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

v-shenoy
Copy link
Contributor

Signed-off-by: Vighnesh Shenoy [email protected]

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added

Fixes #3241

Relates to #2737

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jul 15, 2022

/run-e2e mongo
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

Any idea why the tests are queued for so long? @JorTurFer

Signed-off-by: Vighnesh Shenoy <[email protected]>
@v-shenoy v-shenoy marked this pull request as ready for review July 15, 2022 15:33
@v-shenoy v-shenoy requested a review from a team as a code owner July 15, 2022 15:33
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Jul 15, 2022

/run-e2e mongo
Update: You can check the progress here

@JorTurFer
Copy link
Member

Any idea why the tests are queued for so long? @JorTurFer

I have changed the previous approach of using GH concurrency to the approach of using a single runner to not lose any execution during the process. Now we are working 3 people running e2e tests, and it could produce longer delays waiting for the resources.
It's true that we have "higher" concurrency than usually . With e2e tests migration, we are enqueueing more e2e tests and even thought I optimized the process, it's not enough.
Let's see if we need to address this with other solution or if it's only a temporal problem related with the migrations.

@JorTurFer JorTurFer merged commit abe1f96 into kedacore:main Jul 15, 2022
@v-shenoy
Copy link
Contributor Author

Ah, got it. Probably won't be as much of a problem once the migrations are done.

The only cases where it might be a problem is when some PR requires the entire e2e suite to be run.

@v-shenoy v-shenoy deleted the mongo-e2e branch July 15, 2022 16:01
@JorTurFer
Copy link
Member

JorTurFer commented Jul 15, 2022

The only cases where it might be a problem is when some PR requires the entire e2e suite to be run.

yes, and that is not really often

@zroubalik
Copy link
Member

@v-shenoy do you think that you can also implement the activation* for this scaler?
#2800

#3383

@v-shenoy
Copy link
Contributor Author

@zroubalik Sorry, I don't think I will be able to take this up. Have some personal things going on.

@JorTurFer
Copy link
Member

JorTurFer commented Jul 19, 2022

I'll do it, no worries

@zroubalik
Copy link
Member

@zroubalik Sorry, I don't think I will be able to take this up. Have some personal things going on.

No worries, focus on what's important!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate e2e test for MongoDB to Go
3 participants