Add wait for browser #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2019
As of about Firefox 64, on Windows Firefox uses a separate launcher process which then spawns the browser process. The launcher process will terminate quickly causing karma to think something failed. As with Mozilla's own automation tests we should use -wait-for-browser to make the launcher process wait for the browser process to complete and return its exit code. Unfortunately, killing the launcher process won't kill the browser process so this isn't a complete solution. However, killing the browser process is likely more complicated while simply getting the browser to launch at all is probably enough for local testing.
birtles
force-pushed
the
add-wait-for-browser
branch
from
8799ac2
to
b998193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of about Firefox 64, on Windows Firefox uses a separate launcher process which then spawns the browser process. The launcher process will terminate quickly causing karma to think something failed.
As with Mozilla's own automation tests we should use
-wait-for-browserto make the launcher process wait for the browser process to complete and return its exit code.Unfortunately, killing the launcher process won't kill the browser process so this isn't a complete solution. However, killing the browser process is likely more complicated while simply getting the browser to launch at all is probably enough for local testing.
This builds on top of #94 so I expect you'll want to merge that first.