Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for other paths for Firefox Nightly #94

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

birtles
Copy link
Collaborator

@birtles birtles commented Jul 12, 2019

More recent installs of Firefox Nightly on Windows use "Firefox Nightly" instead of "Nightly" for the application folder. Apparently OSX uses "Firefox Nightly" instead of "FirefoxNightly" too.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@birtles
Copy link
Collaborator Author

birtles commented Jul 12, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

This was referenced Jul 12, 2019
More recent installs of Firefox Nightly on Windows use "Firefox Nightly"
instead of "Nightly" for the application folder. Apparently OSX uses
"Firefox Nightly" instead of "FirefoxNightly" too.
@birtles birtles merged commit 6377ee3 into karma-runner:master Jul 17, 2019
@birtles birtles deleted the update-nightly-path branch July 17, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants