-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random errors : cannot start Firefox/FirefoxHeadless #93
Comments
This, I suspect, is because Firefox uses a separate launcher process (as of Firefox 64?) which triggers a separate process to avoid DLL injection. The launcher process then exits. Apparently previously As a result, karma launcher will see that the launcher process exited while it is still in its |
Actually, it looks like we can fix this just by passing |
https://azimi.me/2014/12/31/kill-child_process-node-js.html describes how to kill a process group but it doesn't seem to work for me on Windows, unfortunately (or at least not under WSL). |
Looks like for talos we watch to see the first child process generated by the firefox process and then record that as the browser process: https://hg.mozilla.org/mozilla-central/rev/8461e2f532ed |
With firefox@68 on Windows 10, I see it fairly consistently fail the first time it tries to launch, and then succeed the second time: First it tries
Then it succeeds
|
Right, that's because the browser process will run in the background and on the second time through it will be running when the launcher tries to connect. Depending on the load on your machine it might connect on the third time or it might fail altogether. With I put up PR #95 for this but there seems to be something wrong with the CI for this repository. Looking at other PRs too it looks like no one is maintaining this anymore so I'm not sure if the PR will get merged. |
On my side, upgrading Firefox to version 68 fixed the issue on Windows 10 (no more project in error, at least the ones I've tested), but not on Ubuntu 19.10 (exactly the same errors). Using a custom launcher with the What I find weird: it's always the same projects that fail, as if it was related to the code rather than Firefox itself. But again: everything is fine if I use Chrome instead of Firefox.
(off topic) Too bad that this project is a Google one... I also find it really sad that Chrome/Chromium has become the dominant browser (and it will not get better with the new MS Edge). |
Ubuntu 18.04 We are seeing the same issue when running inside a Docker container. It was working fine until we upgraded to Firefox 68. Now, the issue is reproducible 100% of the time. We downgraded back to Firefox 67 as a workaround in the mean time. Exact same environment, but not w/ in Docker, we are having no issues. Weird. |
We are having also the issue since Firefox 68 and can not run our tests anymore :-( We can repro on any env using FF 68 with https://github.com/BabylonJS/Babylon.js |
@sebavan Thanks for confirming. I was planning on digging into the Ubuntu issues in #93 before releasing (assuming I even have the access required to submit a new release) but haven't had a chance to set up a VM for it yet. Let me have another look at Ubuntu later this week (I'm currently traveling) and if I can't fix it easily I'll try to release another version. |
Sorry, this is taking longer than expected (having trouble with the VM). |
@cedx I tried to repro this on a clean install of Ubuntu 18.04 but it looks like neither of those projects use |
So I can't repro issues on Ubuntu 18.04 with Firefox 68 and there is at least one report of this fixing things for others so I'm inclined to close this issue. (There is still the issue of the browser process not being killed but that is tracked in #101.) If anyone else has repro steps for things failing to start in Firefox 68 please let me know. |
Have you tried running w/ in Docker? Makes absolutely no sense, but what I've seen is everything works fine on a native install of Ubuntu 18.04. But when ran w/ in Docker, problem is reproducible 100% of the time. We downgraded to Firefox 67 to workaround. |
Ok, I tried to repro this with the following steps:
but everything seemed to work:
|
@birtles Thanks for trying. I'm currently on a vacation, or else I'd give it a try again. I can when I get back, but at the same time, I'm ok if you'd like to close the issue. |
Ok thanks @ericcarino! I'll close this for now. Please file a new issue if you can reproduce it once you get back. |
I am hitting the same issue on macOS Sonoma even without using Docker; I submitted #328 with more details. |
Firefox : v67.0.3
OS : Ubuntu 19.04 and Windows 10
Karma : v4.1.0
Firefox launcher : v1.1.0
Node.js : v12.4.0
I've some projects whose Karma tests work as expected when I'm using the Chrome launcher. But when I use the Firefox launcher, I get the following error:
This error seems to be random: on some projects, the launcher works as expected (for example: https://github.com/cedx/lcov.js). On other projects, the launcher triggers the error (for example: https://github.com/cedx/enum.js).
For the projects that fail, it also seems to be random: the error is triggered on Ubuntu 19.04 and Windows 10, but not on TravisCI with Ubuntu 16.04 (for example: https://travis-ci.com/cedx/enum.js/jobs/209733946).
My Karma config (which is the same on the two mentioned projects):
Using
Firefox
, instead ofFirefoxHeadless
, does not change anything (i.e. same error).The text was updated successfully, but these errors were encountered: