Add VoxSherpa TTS to Projects using sherpa-onnx - #3384
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's documentation by featuring a new application, VoxSherpa TTS, which leverages the sherpa-onnx library. This addition provides a concrete example of the library's capabilities in an offline Android Text-to-Speech context, offering valuable visibility and a practical demonstration for the community. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
📝 WalkthroughWalkthroughAdded a new project entry for VoxSherpa TTS to the README's "Projects using sherpa-onnx" section, including GitHub link, descriptive text, APK download link, platform/feature badges, and a screenshot gallery with four thumbnails. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
There was a problem hiding this comment.
Code Review
This pull request adds VoxSherpa TTS to the list of projects using sherpa-onnx. The change is well-formatted and provides a good overview of the project. I have one suggestion to improve the long-term maintainability of the README by making the image links more robust.
|
|
||
| | Generate | Models | Library | Settings | | ||
| |:---:|:---:|:---:|:---:| | ||
| | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/1.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/2.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/3.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/4.jpg" width="180"/> | |
There was a problem hiding this comment.
The images are currently hotlinked from the main branch of the VoxSherpa-TTS repository. This could lead to broken images in the future if the files are moved, renamed, or the source repository is removed. To ensure the images are permanently available, it's recommended to upload them to this repository or use GitHub's asset hosting. You can do this by dragging and dropping the images into a comment on this pull request and then using the generated URLs. The BreezeApp section below provides an example of this approach.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 314: The four <img> tags in the README (phoneScreenshots/1.jpg, 2.jpg,
3.jpg, 4.jpg) are missing alt attributes; add meaningful alt text to each tag
(e.g., alt="App screenshot: [brief description]") so screen readers can describe
the images, ensuring each <img> tag includes an alt attribute and not empty
unless purely decorative.
|
|
||
| | Generate | Models | Library | Settings | | ||
| |:---:|:---:|:---:|:---:| | ||
| | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/1.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/2.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/3.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/4.jpg" width="180"/> | |
There was a problem hiding this comment.
Add alt text to screenshot images for accessibility.
Line 314 uses four <img> tags without alt attributes, which hurts screen-reader support.
♿ Proposed fix
-| <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/1.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/2.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/3.jpg" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/4.jpg" width="180"/> |
+| <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/1.jpg" alt="VoxSherpa Generate screen" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/2.jpg" alt="VoxSherpa Models screen" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/3.jpg" alt="VoxSherpa Library screen" width="180"/> | <img src="https://raw.githubusercontent.com/CodeBySonu95/VoxSherpa-TTS/main/fastlane/metadata/android/en-US/images/phoneScreenshots/4.jpg" alt="VoxSherpa Settings screen" width="180"/> |🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 314-314: Images should have alternate text (alt text)
(MD045, no-alt-text)
[warning] 314-314: Images should have alternate text (alt text)
(MD045, no-alt-text)
[warning] 314-314: Images should have alternate text (alt text)
(MD045, no-alt-text)
[warning] 314-314: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 314, The four <img> tags in the README
(phoneScreenshots/1.jpg, 2.jpg, 3.jpg, 4.jpg) are missing alt attributes; add
meaningful alt text to each tag (e.g., alt="App screenshot: [brief
description]") so screen readers can describe the images, ensuring each <img>
tag includes an alt attribute and not empty unless purely decorative.
csukuangfj
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
VoxSherpa TTS is a 100% offline Android TTS app for Android built
with Sherpa-ONNX. It supports Kokoro-82M, Piper, and VITS engines
with Hindi, English, Japanese, Chinese and 50+ language support.
GitHub: https://github.com/CodeBySonu95/VoxSherpa-TTS
Summary by CodeRabbit