Add Domia to the projects using sherpa-onnx - #3793
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughREADME.md adds Domia to the “Projects using sherpa-onnx” section and describes its in-process use of sherpa-onnx for speech and audio capabilities with per-companion model configuration. ChangesDomia README listing
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 515: Update the README description of Domia to remove the “open-source”
label and use “source-available” or the project’s current licensing description
instead, consistent with Domia Core’s BSL 1.1 status.
- Around line 518-522: Qualify the deployment and privacy claims in the README
description, especially “Home Assistant included” and “No cloud, no accounts,
and no data leaving your network.” Mark Home Assistant integration as planned or
optional and acknowledge optional cloud hosting and possible data transfer,
while preserving the intended local-network capabilities.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
csukuangfj
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
I've been building Domia for the past year — a project I'm truly passionate about — and sherpa-onnx has been a huge part of making it possible. I'd love to share it here among the projects using sherpa-onnx.
Thank you for building and maintaining such a useful project!
Summary by CodeRabbit