Skip to content

Add Domia to the projects using sherpa-onnx - #3793

Merged
csukuangfj merged 1 commit into
k2-fsa:masterfrom
kecoco16:add-domia-to-projects
Jul 24, 2026
Merged

csukuangfj merged 1 commit into
k2-fsa:masterfrom
kecoco16:add-domia-to-projects

Conversation

@kecoco16

@kecoco16 kecoco16 commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

I've been building Domia for the past year — a project I'm truly passionate about — and sherpa-onnx has been a huge part of making it possible. I'd love to share it here among the projects using sherpa-onnx.

Thank you for building and maintaining such a useful project!

Summary by CodeRabbit

  • Documentation
    • Added Domia to the list of projects using sherpa-onnx.
    • Documented Domia’s support for keyword spotting, voice activity detection, speech recognition, and text-to-speech.

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

README.md adds Domia to the “Projects using sherpa-onnx” section and describes its in-process use of sherpa-onnx for speech and audio capabilities with per-companion model configuration.

Changes

Domia README listing

Layer / File(s) Summary
Add Domia project entry
README.md
Adds Domia to the project list and documents its keyword spotting, VAD, streaming/offline speech recognition, text-to-speech, and per-companion model configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: csukuangfj

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding Domia to the sherpa-onnx projects list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 515: Update the README description of Domia to remove the “open-source”
label and use “source-available” or the project’s current licensing description
instead, consistent with Domia Core’s BSL 1.1 status.
- Around line 518-522: Qualify the deployment and privacy claims in the README
description, especially “Home Assistant included” and “No cloud, no accounts,
and no data leaving your network.” Mark Home Assistant integration as planned or
optional and acknowledge optional cloud hosting and possible data transfer,
while preserving the intended local-network capabilities.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 39da9c33-fada-4f72-91ca-f8c5302b98bc

📥 Commits

Reviewing files that changed from the base of the PR and between a6ebe74 and d83e9b7.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md
Comment thread README.md

@csukuangfj csukuangfj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants