Skip to content

Update VoxSherpa TTS link for stable APK releases - #3648

Merged
csukuangfj merged 3 commits into
k2-fsa:masterfrom
CodeBySonu95:master
Jun 1, 2026
Merged

csukuangfj merged 3 commits into
k2-fsa:masterfrom
CodeBySonu95:master

Conversation

@CodeBySonu95

@CodeBySonu95 CodeBySonu95 commented May 30, 2026 •

Copy link
Copy Markdown
Contributor

Hi, I have updated the download link for VoxSherpa TTS to the latest stable version (v2.9.1) which includes major performance improvements and bug fixes. Please review and merge

Summary by CodeRabbit

  • Documentation
    • Updated the "Projects using sherpa-onnx" entry for VoxSherpa TTS to replace the prior APK link with a "Download APK (All Versions)" link pointing to the app's GitHub releases page.

Review Change Stack

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 30, 2026
@coderabbitai

coderabbitai Bot commented May 30, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR updates the VoxSherpa TTS entry in README.md, replacing the APK download URL to point to the project's GitHub Releases "Download APK (All Versions)" page.

Changes

VoxSherpa TTS Project Link Update

Layer / File(s) Summary
VoxSherpa TTS APK link update
README.md
Updated the VoxSherpa TTS "Download APK" hyperlink to point to the GitHub Releases "Download APK (All Versions)" page instead of the previous Hugging Face v1.0-beta URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • k2-fsa/sherpa-onnx#2672: Both PRs modify README.md by updating entries under the “Projects using sherpa-onnx” section.
  • k2-fsa/sherpa-onnx#3384: Both PRs updated the VoxSherpa TTS APK download link to point to the app’s GitHub releases page.
  • k2-fsa/sherpa-onnx#2498: Both PRs change README.md documentation by adding/updating links in the “Projects using sherpa-onnx” section.

Suggested reviewers

  • csukuangfj

Poem

🐰 I hopped through README lines at play,
Swapped a link so downloads find their way,
From Hugging Face to Releases bright,
A tiny fix — the docs now right,
I nibble carrots, then I sway. 🍃

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the main change: updating the VoxSherpa TTS APK download link from a Hugging Face URL to the GitHub releases page for stable versions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the APK download link in the README.md to point to version 2.9.1. The feedback suggests improving the readability and consistency of the link text by formatting it as 'Download APK v2.9.1' instead of using the raw filename with underscores.

Comment thread README.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@csukuangfj

Copy link
Copy Markdown
Collaborator

Could you create a dedicated page in your repository with a fixed URL, and host all versions of the APK there?
This way, you won’t need to update sherpa-onnx regularly.

@CodeBySonu95 CodeBySonu95 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the PR to replace the direct .apk link with a fixed URL pointing to the GitHub Releases page of my repository.
This page will permanently host all current and future versions of the APK, ensuring users always have access to the latest version without requiring any further updates to the sherpa-onnx README.

@CodeBySonu95 CodeBySonu95 changed the title Update VoxSherpa TTS APK link to v2.9.1 Update VoxSherpa TTS link for stable APK releases May 30, 2026

@csukuangfj csukuangfj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants