fix(update_metadata): Update Metadata for any connectors other than stripe gives 500 error

[Nithin1506200]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

Update metadata gives 500 error for other connectors than stripe
Change this to 400

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

• Make a successful payment using any connector other than stripe
• make update metadata request

curl --location 'http://localhost:8080/payments/pay_X77ffJsUvEW94JadFVpw/update_metadata' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_bTSpZN98PGIduROqZNoagEkN7XUxd7dof6cgl8K061T2Vvw6rRaplOVejfRiYUI9' \
--data '{
    "metadata": {
        "order_id": "999999897989",
        "dbehcb": "2324",
        "abb": "efe"
    }
}'

Response should be 400

{
    "error": {
        "type": "connector",
        "message": "IR_20: Flow is not implemented for this connector",
        "code": "CE_00",
        "connector": "cybersource"
    }
}

• update metadata for successful payment created via stripe should give success response

{
    "payment_id": "pay_fvWhpXtZwWZSE1JfTUI4",
    "metadata": {
        "abb": "efe",
        "dbehcb": "2324",
        "order_id": "999999897989"
    }
}

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/core/payments/flows/update_metadata_flow.rs	91% smaller
crates/router/src/core/payments/transformers.rs	0% smaller

[sai-harsha-vardhan]

Should we throw BadRequest instead?