-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(vsaas): integrate onboarding flow for vertical saas #7884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor concerns.
@@ -0,0 +1,5 @@ | |||
-- Your SQL goes here | |||
ALTER TABLE organization ADD COLUMN IF NOT EXISTS organization_type VARCHAR(64) NOT NULL DEFAULT 'standard'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not add NOT NULL based alter query, and make default in database instead use default value in code and have nullable value in database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In code it is having default value, but in DB I made it default because that will help to backfill all previous standard cases.
If we don't make it default then we need to run separate migration to backfill old data, is this fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can handle the null cases in code itself
ALTER TABLE organization ADD COLUMN IF NOT EXISTS organization_type VARCHAR(64) NOT NULL DEFAULT 'standard'; | ||
ALTER TABLE organization ADD COLUMN IF NOT EXISTS platform_merchant_id VARCHAR(64); | ||
|
||
ALTER TABLE merchant_account ADD COLUMN IF NOT EXISTS merchant_account_type VARCHAR(64) NOT NULL DEFAULT 'standard'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not add NOT NULL based alter query, and make default in database instead use default value in code and have nullable value in database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can handle the null cases in code itself
…adyen-ideal * 'main' of github.com:juspay/hyperswitch: (62 commits) fix(core): language consumption from locale in payment and payout links (#7993) feat(refunds_v2): Add refunds list flow in v2 apis (#7966) refactor(connector): [Noon] auth header (#7977) fix(connector): [Novalnet] send decoded token for apple pay payment (#7973) feat(business_profile): add business_profile config to enable external vault (#7876) feat(vsaas): integrate onboarding flow for vertical saas (#7884) feat(connector): Introduce connector template code for WorldpayXML (#7968) feat(connector): [ADYEN, CHECKOUT] Added In Feature Matrix API (#7914) feat(core): add psync support for recovery external payments (#7855) refactor(open_router): call elimination routing of open router if enabled instead of dynamo (#7961) feat(payment_methods): add v2 api for fetching token data (#7629) ci(cypress): Fix Bank Redirects for stripe test (#8004) chore(version): 2025.05.12.0 refactor(authentication): moved cavv storing from table to temp locker (#7978) chore(version): 2025.05.09.0 feat(connector): [paypal, trustpay] add in feature matrix (#7911) fix(update_metadata): Update Metadata for any connectors other than stripe gives 500 error (#7984) fix(router): Fixed stack over flow for session call in authentication connectors (#7983) chore(version): 2025.05.08.0 fix(payment): disable payment update via client config (#7970) ...
Type of Change
Description
The PR supports onboarding for new VSAAS merchants.
Additional Changes
Motivation and Context
Closes #7889
How did you test it?
Following Flow:
We can hit the following curls:
Signup
Response:
Terminate 2FA
Response
Create Merchant Account
Response:
List Orgs
Response:
List Merchant
Response:
Create Platform Org
Response: status 200 OK, witth reponse containing platform details
Switch Org
Resonse:
Create Merchant inside Platfrom
Response:
List Org
Now the list orgs for user will give following response since there are two orgs
List Merchant
Inside platform there will be following merchants
Checklist
cargo +nightly fmt --all
cargo clippy