refactor(authentication): moved cavv storing from table to temp locker

[sahkal]

Type of Change

• Refactoring

Description

moved cavv storing from table to temp locker

Motivation and Context

Currently we are storing CAVV value in authentication table which might cause a security issue to resolve that we will be storing the CAVV in temp locker and fetch it in the current session while proceeding with the transaction.

How did you test it?

Check sanity of 3ds flows such as Netcetera, 3dsecure.io

Do Payments Create

curl --location 'localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_ChBq2jsHNemvjysRrur7R62Xlk5acxmaneYdGdYu05Rn4yPtnj8uySMIVd8qnqBa' \
--data-raw '{
    "amount": 6540,
    "currency": "USD",
    "confirm": false,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 6540,
    "customer_id": "StripeCustomer",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "three_ds",
    "return_url": "https://duck.com",
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "PiX",
            "last_name": "ieuhfuqe"
        },
        "phone": {
            "number": "123456789",
            "country_code": "12"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "PiX"
        },
        "phone": {
            "number": "123456789",
            "country_code": "12"
        }
    },
    "request_external_three_ds_authentication": true,
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "force_3ds_challenge": false
}'

Do version call in payments confirm

curl --location 'localhost:8080/payments/pay_FMW9BlITyGdXbkqFqGCr/confirm' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_ChBq2jsHNemvjysRrur7R62Xlk5acxmaneYdGdYu05Rn4yPtnj8uySMIVd8qnqBa' \
--data '{
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "115.99.183.2"
    },
    
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "card_number": "card_number", 
            "card_exp_month": "10",
            "card_exp_year": "25",
            "card_holder_name": "joseph Doe",
            "card_cvc": "cvc"
        }
    }
}'

authenticate via browser

curl --location 'http://localhost:8080/payments/pay_FMW9BlITyGdXbkqFqGCr/3ds/authentication' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: pk_dev_9dd8d1dc9c24494ab149ee4364874671' \
--data '{
    "client_secret": "pay_FMW9BlITyGdXbkqFqGCr_secret_HcardpDpDtFO0wOpi8nA",
    "device_channel": "BRW",
    "threeds_method_comp_ind": "N"
}'

Authorise

curl --location 'localhost:8080/payments/pay_FMW9BlITyGdXbkqFqGCr/sahkal/authorize/cybersource' \
--header 'Content-Type: application/json' \
--header 'api-key: pk_dev_9dd8d1dc9c24494ab149ee4364874671' \
--data '{
    "client_secret": "pay_FMW9BlITyGdXbkqFqGCr_secret_HcardpDpDtFO0wOpi8nA"
}'

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/core/payments/transformers.rs	73% smaller
crates/router/src/core/payments.rs	71% smaller
crates/router/src/types/transformers.rs	71% smaller
crates/hyperswitch_connectors/src/connectors/gpayments/gpayments_types.rs	63% smaller
crates/hyperswitch_connectors/src/connectors/netcetera/transformers.rs	63% smaller
crates/hyperswitch_domain_models/src/router_request_types/unified_authentication_service.rs	63% smaller
crates/router/src/connector/threedsecureio/transformers.rs	63% smaller
crates/router/src/core/payments/types.rs	62% smaller
crates/router/src/core/authentication.rs	58% smaller
crates/hyperswitch_domain_models/src/router_response_types.rs	50% smaller
crates/hyperswitch_interfaces/src/authentication.rs	50% smaller
crates/router/src/types/api/authentication.rs	50% smaller
crates/router/src/core/payments/operations/payment_confirm.rs	46% smaller
crates/router/src/core/payments/operations/payment_status.rs	20% smaller
crates/router/src/core/payments/operations/payment_response.rs	8% smaller
crates/diesel_models/src/authentication.rs	0% smaller
crates/hyperswitch_domain_models/src/router_request_types/authentication.rs	0% smaller
crates/router/src/core/authentication/utils.rs	Unsupported file format
crates/router/src/core/unified_authentication_service/utils.rs	Unsupported file format
crates/router/src/core/webhooks/incoming.rs	0% smaller
crates/router/src/types/domain.rs	0% smaller

[deepanshu-iiitu]

Connector changes look good