Pull from Azure/azure-rest-api-specs#1
Merged
Conversation
* Azure Spring Cloud: Add location to Apps * make location read-only for Apps * revert: make location read-only for Apps * put location in PUT/PATCH request examples Co-authored-by: Guoqing Geng <gugeng@microsoft.com>
* Added diffDiskSettings property as part of Swagger changes needed for Ephemeral VM\VMSS * updated comment * updated swagger specs for diffdisksettings property * updated swagger spec comments for diff disk settings [property * added example to create Diff OS disk scaleset * updated 2018-10-01 version specs with diffdisk property * added example file for creating VM with diffdisksettings property * updated swagger changes for reimage operation in single vm * update examples * udpated examples * fixed validation errors * updated comments for reimage operation documentation * Updated examples and documentation for APIs in swagger * updated examples as per review comments * updated swagger documentation * updated swagger documentation with zone details in the sku example * updated swagger documentation and reverted the breaking changes * updated examples as per swagger model * updated swagger to remove the model validation errors for existing examples where we are passing read only parameter in the request * updated swagger * updated swagger * Added new property in DiffDiskSettings * updated swagger spec * udpated swagger * updated swagger spec * updated code * updated code * udpated swagger * updated code
* Add fields to incident properties * Fix example
Have discussed the recommendation of providing Default with correct error schema in order to surface error message to customer. Without it, if the error message format differs from standard cloud error, user of SDK would only get a generic CloudException with error status code but no detailed error message. Adding default with schema LATER would be a SDK breaking change. Monitor team indicated understanding of the issue and with urgent JEDI requirement and opt for this approach.
* base commit to compare with 2019-06-01-preview * adding api version 2019-11-01-preview * add more to protectedAccountKeyName2 description Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
* Add missed properties of Identity. * Fix prettier check. * Add read only according to comment.
…tion update for restoreblobrange (#8920)
…ion preview/2020-03-01-preview (#8740) * Remove x-ms-client-flatten flag from endpoint properties * Adds suppression to readme
* Add Synapse role and role assignment swagger * Remove text/json Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
* Create hybriddata.json Added updated swagger file for Microsoft.HybridData * Create readme.md * Updated readme files * Update readme.md * Removed unused API endpoints * Updated example files and swagger * Fixed error in path to example files * Fixed Go and Ruby Readme Files * Added suppression for OperationIdNounVerb * Added DataManagers_Update and examples * Added suppression for ARM Violation and updated swagger and example files * Updated swagger to sdk script for ruby * Added Python swagger to sdk * Added PartiallySucceeded status * Added swagger and examples for API Version 2019-06-01 Added swagger and examples for API version 2019-06-01 Adding PartiallySucceeded job status * Removed partially succeeded status from 2016-06-01 swagger * Updating body of 202 response * After running prettier Ran npm install; npm run prettier -- --write "specification/hybriddatamanager/**/*.json" * Updated readme files to include 2019-06 api version * Updated descriptions as per PR comments * Committing Prettier check change Co-authored-by: t-prta <46665688+prerna-tank-ms@users.noreply.github.com>
* Added GEt-privateLinkResources API and managedIdentity changes for Vaults * Fixed PrettierCheck failure * Update vaults.json * Update vaults.json * Resolved PR commens related to PrivateLinkResources * Resolved PR comments * resolved PR comments * Using x-ms-client-flatten for PrivateLinkResourceProperties * Fixing examples for PrivateLinkResources * Revert "Fixing examples for PrivateLinkResources" This reverts commit b0d62a2. * Revert "Using x-ms-client-flatten for PrivateLinkResourceProperties" This reverts commit 31ba2d0. * Using x-ms-client-flatten for PrivateLinkResourceProperties * Fixing examples for PrivateLinkResources * Adding description for privateLinkResourceProperties * Resolved PR comments. Fixed SpellCheck and PrettierCheck and Java SDK failures * Changing operationId for PrivateLinkResource to PrivateLinkResources * Renaming PrivateLinkResourceList to PrivateLinkResources Co-authored-by: deymadhumanti <deymadhumanti@users.noreply.github.com> Co-authored-by: asmaskar <asmaskar@microsoft.com> Co-authored-by: asmaskar <58723769+asmaskar@users.noreply.github.com> Co-authored-by: Aman Chandna <amchandn@microsoft.com>
…separate files - JEDI URGENT (#8868) * add public netowrk access flag * add public access flags * add new api version for worksapce resource and align to common definitions * remove from this pr * change all to common types * Update OperationalInsights.json * update examples * remove legacy * fix build * prettier * fix build * Update WorkspacesCreate.json * fix build * Update OperationalInsights.json * Update readme.md * undo all version changes * undo old version * remove breaking change stuff * Update OperationalInsights.json * prettier * remove cluster from pr * Update Workspaces.json * clone resource-manager apis to new version * prettier * Update DataSources.json * split * Update readme.md * Update readme.md * Update readme.md * Update Clusters.json * reference proxy resource from common * commit example * change name * Update Operations.json * Update OperationalInsights.json * examples fix * fix examples * Update Operations.json * exclude old version files from this pr * remove from this pr * Update Operations.json * Update Clusters.json * Update OperationsListByTenant.json * Update Clusters.json * Update Clusters.json * new api version * remove from 2019 * workspaces * new package * use common error * merge from cluster pr * fix validation * Update Clusters.json * Update Clusters.json * change default tag to package-2020-03-preview * fix lint errors * Update Workspaces.json * Update WorkspacesUpdate.json * fix lint * add responses * Update DataExports.json * Update DataExportListByWorkspace.json * Update Clusters.json * fix skuenum name * typo * Fix linked services example * add missing opreations for cmdlets * add common * move like other RPs * Update readme.md * reference all from common * prettier * Update types.json Co-authored-by: MyronFanQiu <49134743+MyronFanQiu@users.noreply.github.com> Co-authored-by: Or Argaman <orargaman@gmail.com>
* swagger documentation for data plane PolicyStates API * enable events api in 2019-10-01 api version * data plane events API and data plane states API fixes * Data plane sample fixes and resolving autorest tool compile errors Data plane sample fixes and resolving autorest tool compile errors * Added more examples for dp and minor fixes Added more examples for dp and minor fixes * Update api version in exisiting events API examples Update api version in exisiting events API examples to be 2019-10-01 * Fix model validator errors Fix model validator errors * Remove aggrigate data plane events and states examples from swagger Remove aggrigate data plane events and states examples from swagger * Revert - Add back references to aggrigated component counts Revert - Add back references to aggrigated component counts * Added additional properties bag to data plane json object Added additional properties bag to data plane json object * Added policyEvents for 2019-10-01 in readme * fixed sample ref file path * Addressed PR review feedback Addressed PR review feedback * Fix SDK automation error SDK automation is throwing an error if the parameter descriptions for $expand do not match across PolicyStates and PolicyEvents API. * Fix prettier Co-authored-by: Phoenix He <tih@microsoft.com>
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
* [Storage] Add object replication policy * Fix spellcheck and prettier check
* use same parameters as other API for 2019-10-17-preview * update privateLinkScopes_API.json for dotnet SDK generation, parameter/definition conflict * add ErrorResponseCommon to inherit from ErrorResponse and match common ErrorResponse type * update reference for scopedresource * Update privateLinkScopes_API.json * remove PrivateProxyResource since it's identical with ProxyResource * add privateEndpointConnections * add examples for private link * change parameter from resourcename to privatelinkscopename * remove x-ms-azure-resource: true, child class cannot inherit parent class because of this * create definition 'ErrorCommon' as error in response * Update privateLinkScopes_API.json * add ErrorCommon back as error response instead of ErrorResponseCommon * Update privateLinkScopes_API.json Co-authored-by: Arie Olshanezky <arolshan@microsoft.com>
…8813) * Changes to CheckRequirements - for better auto generate * Ran prettier-fix
* commit fbe7670 Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 10 14:06:55 2020 -0700 Update resourceGroups casing commit 848e5f7 Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 10 14:05:10 2020 -0700 Update resourcegroups casing to resourceGroups commit 591ff3c Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 10 13:58:14 2020 -0700 Update Updates.json commit 9e551f0 Author: bganapa <bganapa@microsoft.com> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (#7766) * Address PR comments
* resourcegraph trenton * trenton pipeline * test windowsiot pipeline Co-authored-by: root <root@cjf.1nfgrxx31qve3h2ogd1kz2gjvd.cx.internal.cloudapp.net>
* Added User identities for compute * Changing the api version * Revert "[Do not Merge] Adding user identities" * Adding userassigned identities for compute * running prettier * Updating Quota examples * Undoing Quota examples * Updating the examples fine * Updating Quota examples Co-authored-by: Shail Paragbhai Shah <shaisha@microsoft.com> Co-authored-by: Sriram Kakara <skakara@microsoft.com>
* [Storage] Add support for listing private endpoint connections This change adds support for listing private endpoint connections through a GET collection API for Microsoft.Storage/storageAccounts/privateEndpointConnections. * Update StorageAccountListPrivateEndpointConnections.json Fixed prettier check fix. * Update storage.json Fixed lintdiff build error
* added SF 7.1 * fixed spelling * added reference to main file * removed unused files * updated tag
* change python client name * change python client name * change title overrider
…s api-version does not need special handling (#8803)
…sion preview/2018-09-01-preview (#9216) * feedback * Linter * Remove additional fields * Revert operation changes * Undo etag capitalization
…9033) * Cumulative commit message: commit 4ec980f (azure/stackadmin) Author: Yuxing Zhou <zyx.pulsars@gmail.com> Date: Wed Mar 18 15:14:57 2020 +0800 [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (#8733) * add scaleUnit and volumeLabel to Disks_List * fix ref location * update parameter description commit dd09a40 Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 17 17:32:10 2020 -0700 Update to camelCasing for resourceGroups commit 4212dd0 Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 17 17:30:07 2020 -0700 Update to camelCasing for resourcegroups commit b62db8ba4e29e14935ff33e82bda029393eb8393 Merge: 08d597a fbe7670 Author: Vishnu Priya Ananthu Sundaram <viananth@microsoft.com> Date: Thu Mar 12 11:23:30 2020 -0700 Merge branch 'stackadmin' of https://github.com/Azure/azure-rest-api-specs into stackadmin commit fbe7670 Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 10 14:06:55 2020 -0700 Update resourceGroups casing commit 848e5f7 Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 10 14:05:10 2020 -0700 Update resourcegroups casing to resourceGroups commit 591ff3c Author: bganapa <bganapa@microsoft.com> Date: Tue Mar 10 13:58:14 2020 -0700 Update Updates.json commit adaabc1 Author: bganapa <bganapa@microsoft.com> Date: Wed Mar 4 18:07:20 2020 -0800 Changing casing in resourcgroups to resourceGroups commit 72efdec Author: bganapa <bganapa@microsoft.com> Date: Thu Feb 27 17:26:56 2020 -0800 Update to have $(this-folder)/ in the input files * Add autorest config to readme.md * Fix path reference * Auto-generated values
* cli validation for desktopvirtualization * correct readme title Co-authored-by: Changlong Liu <changll@microsoft.com>
… image version is failing when ID is not present (#9257) * remove id as required * update for july too Co-authored-by: Jerry Chan <jerch@microsoft.com>
* Fix bad readme.go.md in azuredata * Fix comments
…9335) * added optional keyVersion property in KeyVaultProperties * Keyvault properties to Array Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
* Adding the new resource type PrivateLinkForAzureAD * Added the example * Updated the example * Updated the definition for privateLinkforAzureAD * Added privatelinkresource * Added privatelinkresource * Updated definitions * Updated definitions * Spell check * Moved to different files * Fixing Model validation * added xmspageable * Fixing example * Added nextlinks and corrected the versions in the examples * Added PUt/PATCH/DELETE to comply with a trackedResource * Fixes for Model Validation + AllTenants Property Fixed the error messages thrown by model validation as well as introduced the "allTenants" property under privatelinkpolicy * Fixes for Prettier Check Pushing fixes done by prettier check Co-authored-by: Arturo Lucatero <arluca@microsoft.com>
Co-authored-by: Xiaoxu Qi <xiaoxuqi@microsoft.com>
* fixing attestation * undo unnecessary changes * missing
…preview/2020-02-10-preview (#8383) * Adds base for updating Microsoft.Insights from version preview/2019-10-17-preview to version 2020-02-10-preview * Updates readme * Updates API version in new specs and examples * Added WebTestResults API * Adjusted tiles * made changes to example file. * Adjusted example to have better sample values * Updated doc to produce better help file. * corrected example file. * added _get to operationId to match GetInOperationName requirement * Adjustments from review * Adjusted enum for downloadAs * Adjusted file to make more readable. * Added better descriptions to the file format enum. * Removed partition ID from the example. * Updated description * Changes made based on Igors review. * removed dashes from example and removed _Get from operationId * Fixes typeo * adjusted with prettier * adjusted json * adjusted to a put call and added operationslist as per code review from arm team. * corrected to post * added operatinsList.json example file * adjusted file name. * adjusted example file. * adjusted case of microsoft.insights * minor fix * ran prettier-fix * changes per code review. * Fixed case in example file. * removed nextLink from Operations
…ion preview/2020-03-01-preview (#9304) * init commit * updates * re-add sku as future use * make sku writeOnly so it is not expected in return * correction * test * fixup
jqhuangonearth
pushed a commit
that referenced
this pull request
May 7, 2020
* 2019-08-09-preview * spell out networks * username and credential needed to add an IdentitySource * post listAdminCredentials * standardize on username, password, nsxt and vcenter * add nsxt to custom-words.txt * default cluster does not have provisioningState * it extends DefaultClusterProperties * add Circuit expressRoutePrivatePeeringID * back out some minor changes for sdk generation * identitySources and Circuit authorizations are updateable * add PrivateClouds_ListInSubscription * Long running operation for Clusters_Delete (#1) * npm run prettier * location for all resources (Azure#2) * Revert "location for all resources (Azure#2)" (Azure#3) This reverts commit 432e37b. * add description TODOs * example is PrivateClouds_Update * require body in PrivateClouds_Update * replaced TODOs with descriptions * spellcheck * "x-ms-secret": true * Revert ""x-ms-secret": true" This reverts commit 3358dff. Co-authored-by: Andrew Ulliani <aulliani@yahoo.com> Co-authored-by: Eugene Tolmachev <e.tolmachev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.