Updated Swagger as per latest changes. by amoghnatu · Pull Request #8427 · Azure/azure-rest-api-specs

amoghnatu · 2020-02-19T00:01:07Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Added the missing 'description' field in CreatedBy element

azure-pipelines · 2020-02-19T00:01:24Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-19T00:03:21Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f953e95 with merge commit 8a8166f. SDK Automation 13.0.17.20200326.3

️✔️azure-mgmt-databricks [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 39.660% size of original (original: 10416 chars, delta: 4131 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model Workspace has a new parameter workspace_id
[ChangeLog]   - Model Workspace has a new parameter created_date_time
[ChangeLog]   - Model Workspace has a new parameter updated_by
[ChangeLog]   - Model Workspace has a new parameter workspace_url
[ChangeLog]   - Model Workspace has a new parameter created_by

openapi-sdkautomation · 2020-02-19T00:03:47Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f953e95 with merge commit 8a8166f. SDK Automation 13.0.17.20200326.3
️✔️databricks/mgmt/2018-04-01 [Logs] [Release SDK Changes]
- databricks.mgmt.2018-04-01.zip

openapi-sdkautomation · 2020-02-19T00:03:55Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-02-19T00:04:56Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-02-19T00:07:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-19T00:07:41Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-19T00:09:14Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from f953e95 with merge commit 8a8166f. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-databricks [Logs] [Release SDK Changes]

azure-arm-databricks-1.1.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-databricks@1.1.0~prepack: cannot run in wd @azure/arm-databricks@1.1.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/databricks/arm-databricks)

amoghnatu · 2020-02-19T00:39:15Z

WaitForARMFeedback
Unable to add the label "WaitForARMFeedback" so addint it as a comment

added readonly attribute to properties

azure-pipelines · 2020-02-19T18:05:35Z

Azure Pipelines successfully started running 1 pipeline(s).

ravrams · 2020-02-19T18:43:27Z

Can you please update with below changes as discussed offline.

New property 'properties.parameters.enableFedRampCertified'
Returning 'properties.CreatedDateTime'
VNet peering in the operation list
AML workspace id in the example should be a resource uri
Sku name value should be allowed value (in the example)
Revert changes to remove properties
Update examples as well.

Fixed all the below review comments. 1. New property 'properties.parameters.enableFedRampCertified' 2. Returning 'properties.CreatedDateTime' 3. VNet peering in the operation list 4. AML workspace id in the example should be a resource uri 5. Sku name value should be allowed value (in the example) 6. Revert changes to remove properties 7. Update examples as well.

azure-pipelines · 2020-02-19T22:23:15Z

Azure Pipelines successfully started running 1 pipeline(s).

amoghnatu · 2020-02-19T22:30:50Z

@yungezz can you confirm when we can merge this PR?

Fixed model validation errors.

yungezz · 2020-03-06T08:09:41Z

          "description": "Specifies the date and time when the workspace is created.",
          "$ref": "#/definitions/CreatedDateTime"
+        },
+        "workspaceId": {


adding properties to existing version is breaking change. need to do it in new version

@yungezz We're going to backfill all existing databricks workspaces with these 2 properties. Any new workspaces created with this api-version will get these 2 properties by default. And all existing workspaces, we're going to backfill them next week. So this shouldn't technically remain as a breaking change after the backfilling is done. Also, since the backfill process is scheduled for next week, we request you to put a "DoNotMerge" label until we complete the process.

HI @amoghnatu, thanks for sharing this. Adding new properties in response will break the GET-PUT pipeline, here's guideline of breaking change https://github.com/Azure/adx-documentation-pr/wiki/Breaking-changes-guidelines#new-property-added-to-response

@yungezz Thanks for mentioning this. However, in our case, these 2 new properties are readonly and the customer will not be able to set them. Also, these are not available in the template so user cannot set them to provide as input. I have updated the spec to include readonly=true for these 2 properties. Kindly check.

yungezz · 2020-03-06T08:10:56Z

since there're new properties added after ARM signoff. need ARM review again. Wait for ARM review.

azure-pipelines · 2020-03-06T19:49:26Z

Azure Pipelines successfully started running 1 pipeline(s).

akning-ms · 2020-03-10T07:17:37Z

Hi @amoghnatu, Looks there is some change for package-lock.json file in your PR which is not supposed in swagger PR. can you remove this file change in this PR? Thanks

azure-pipelines · 2020-03-10T18:04:23Z

Azure Pipelines successfully started running 1 pipeline(s).

amoghnatu · 2020-03-10T18:05:44Z

@akning-ms Thanks for pointing it out. I have removed the file.

azure-pipelines · 2020-03-12T08:01:54Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-12T08:11:31Z

Azure Pipelines successfully started running 1 pipeline(s).

ravbhatnagar · 2020-03-12T18:21:10Z

signing off from ARM side.

yungezz · 2020-03-12T23:50:32Z

hi @amoghnatu, could you pls fix CI failure, then the PR ok to merge.

azure-pipelines · 2020-03-16T22:37:46Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-16T22:39:28Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

yungezz · 2020-03-19T02:19:36Z

hi @amoghnatu could you pls fix CI?

yungezz · 2020-03-26T13:38:04Z

ping @amoghnatu

azure-pipelines · 2020-04-06T09:07:54Z

Azure Pipelines successfully started running 1 pipeline(s).

Amogh Natu and others added 2 commits February 18, 2020 09:05

Updated Swagger as per latest changes.

ceb6e22

Added description field

2503391

Added the missing 'description' field in CreatedBy element

openapi-assignment-bot Bot assigned yungezz Feb 19, 2020

openapi-sdkautomation Bot mentioned this pull request Feb 19, 2020

[AutoPR azure-mgmt-databricks] Updated Swagger as per latest changes. AzureSDKAutomation/azure-sdk-for-python#361

Closed

amoghnatu requested a review from achandmsft February 19, 2020 00:07

openapi-sdkautomation Bot mentioned this pull request Feb 19, 2020

[AutoPR @azure/arm-databricks] Updated Swagger as per latest changes. AzureSDKAutomation/azure-sdk-for-js#467

Closed

yungezz reviewed Feb 19, 2020

View reviewed changes

Comment thread ...ification/databricks/resource-manager/Microsoft.Databricks/stable/2018-04-01/databricks.json

Comment thread ...ification/databricks/resource-manager/Microsoft.Databricks/stable/2018-04-01/databricks.json

yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 19, 2020

amoghnatu requested a review from yungezz February 19, 2020 00:42

ravrams reviewed Feb 19, 2020

View reviewed changes

Comment thread ...bricks/resource-manager/Microsoft.Databricks/stable/2018-04-01/examples/WorkspaceCreate.json

yungezz reviewed Feb 19, 2020

View reviewed changes

Comment thread ...ification/databricks/resource-manager/Microsoft.Databricks/stable/2018-04-01/databricks.json

added readonly attribute

8e6467e

added readonly attribute to properties

amoghnatu requested review from ravrams, vladimirjoanovic and yungezz February 19, 2020 22:24

Fixed model validation errors

8277de2

Fixed model validation errors.

yungezz reviewed Mar 6, 2020

View reviewed changes

yungezz removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 6, 2020

Added readonly to new properties.

a7ea409

Reverted change in package.lock.json

55459a6

Added missing 200 response on delete.

41d5aec

fixed model validation error.

d7f4879

ravbhatnagar approved these changes Mar 12, 2020

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 12, 2020

yungezz approved these changes Mar 12, 2020

View reviewed changes

Removed FedRAMP parameter from api-version

f953e95

yungezz closed this Apr 6, 2020

yungezz reopened this Apr 6, 2020

yungezz added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 7, 2020

yungezz merged commit 8a8166f into Azure:master Apr 7, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Updated Swagger as per latest changes. (Azure#8427)

ece9cfb

Uh oh!

Conversation

amoghnatu commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines Bot commented Feb 19, 2020

Uh oh!

openapi-sdkautomation Bot commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation Bot commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

azure-pipelines Bot commented Feb 19, 2020

Uh oh!

azure-pipelines Bot commented Feb 19, 2020

Uh oh!

openapi-sdkautomation Bot commented Feb 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

amoghnatu commented Feb 19, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Feb 19, 2020

Uh oh!

ravrams commented Feb 19, 2020

Uh oh!

azure-pipelines Bot commented Feb 19, 2020

Uh oh!

amoghnatu commented Feb 19, 2020

Uh oh!

yungezz Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

amoghnatu Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

yungezz Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

amoghnatu Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

yungezz commented Mar 6, 2020

Uh oh!

azure-pipelines Bot commented Mar 6, 2020

Uh oh!

akning-ms commented Mar 10, 2020

Uh oh!

azure-pipelines Bot commented Mar 10, 2020

Uh oh!

amoghnatu commented Mar 10, 2020

Uh oh!

azure-pipelines Bot commented Mar 12, 2020

Uh oh!

azure-pipelines Bot commented Mar 12, 2020

Uh oh!

ravbhatnagar commented Mar 12, 2020

Uh oh!

yungezz commented Mar 12, 2020

Uh oh!

azure-pipelines Bot commented Mar 16, 2020

Uh oh!

amoghnatu commented Feb 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 19, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Mar 16, 2020 •

edited

Loading