Skip to content

[Synapse Control Plane]Add Firewall Rules Get API#8930

Merged
leniatgh merged 1 commit into
Azure:masterfrom
aim-for-better:AddSynapseFirewallRulesGetAPI
Apr 7, 2020
Merged

[Synapse Control Plane]Add Firewall Rules Get API#8930
leniatgh merged 1 commit into
Azure:masterfrom
aim-for-better:AddSynapseFirewallRulesGetAPI

Conversation

@aim-for-better

@aim-for-better aim-for-better commented Apr 3, 2020

Copy link
Copy Markdown
Member

Add Firewall Rules Get API

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@aim-for-better aim-for-better added WaitForARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMReview labels Apr 3, 2020
@openapi-sdkautomation

openapi-sdkautomation Bot commented Apr 3, 2020

Copy link
Copy Markdown

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation

openapi-sdkautomation Bot commented Apr 3, 2020

Copy link
Copy Markdown

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation

openapi-sdkautomation Bot commented Apr 3, 2020

Copy link
Copy Markdown

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 4a66e55 with merge commit 55bc95d. SDK Automation 13.0.17.20200326.3
  • ️✔️@azure/arm-synapse [Logs]  [Release SDK Changes]
    [npmPack] npm WARN lifecycle @azure/arm-synapse@1.0.0~prepack: cannot run in wd @azure/arm-synapse@1.0.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/synapse/arm-synapse)

@openapi-sdkautomation

openapi-sdkautomation Bot commented Apr 3, 2020

Copy link
Copy Markdown

azure-sdk-for-java - Release

failed [Logs] [Expand Details]
  • Generate from 4a66e55 with merge commit 55bc95d. SDK Automation 13.0.17.20200326.3
    [AutoRest] FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/IntegrationRuntimeNodeIpAddress.java
    [AutoRest]    at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 106
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
    [AutoRest] --- End of stack trace from previous location where exception was thrown ---
    [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
    [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    [AutoRest] FATAL: java/generate - FAILED
    [AutoRest] FATAL: Error: Plugin java reported failure.
    [AutoRest] Failure during batch task - {"tag":"package-2019-06-01-preview"} -- Error: Plugin java reported failure..
    [AutoRest]   Error: Plugin java reported failure.
    Failed to run autorest.
    Error: /z/node_modules/.bin/autorest --version=2.0.4413 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@2.1.95 --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/synapse/resource-manager/readme.md FATAL: System.Exception: Duplicate File Generation: src/main/java/com/microsoft/azure/management/synapse/v2019_06_01_preview/IntegrationRuntimeNodeIpAddress.java
       at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 106
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
       at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
    FATAL: java/generate - FAILED
    FATAL: Error: Plugin java reported failure.
    Failure during batch task - {"tag":"package-2019-06-01-preview"} -- Error: Plugin java reported failure..
      Error: Plugin java reported failure.
    , {} 

@openapi-sdkautomation

openapi-sdkautomation Bot commented Apr 3, 2020

Copy link
Copy Markdown

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 4a66e55 with merge commit 55bc95d. SDK Automation 13.0.17.20200326.3
  • ️✔️azure-mgmt-synapse [Logs]  [Release SDK Changes]
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
    [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
    [ChangeLog] Size of delta 37.044% size of original (original: 111120 chars, delta: 41163 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Added operation IpFirewallRulesOperations.get
    [ChangeLog]   - Added operation group IntegrationRuntimesOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeAuthKeysOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeNodesOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeStatusOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeMonitoringDataOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeCredentialsOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeNodeIpAddressOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeObjectMetadataOperations
    [ChangeLog]   - Added operation group IntegrationRuntimeConnectionInfosOperations

@openapi-sdkautomation

openapi-sdkautomation Bot commented Apr 3, 2020

Copy link
Copy Markdown

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@azuresdkci

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@aim-for-better aim-for-better requested a review from majastrz April 4, 2020 16:59
@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 5, 2020

@majastrz majastrz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

@leniatgh leniatgh merged commit 55bc95d into Azure:master Apr 7, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants