Merged
Conversation
🦋 Changeset detectedLatest commit: 84b373f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
benpryke
approved these changes
Mar 28, 2022
LukeSheard
approved these changes
Mar 28, 2022
Merged
cristiano-belloni
pushed a commit
that referenced
this pull request
Apr 5, 2022
This reverts commit d896289.
LukeSheard
pushed a commit
that referenced
this pull request
Apr 12, 2022
This reverts commit d896289.
LukeSheard
added a commit
that referenced
this pull request
Apr 28, 2022
* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Update snapshots * Remove alpha release artifacts * Update snapshots * Update snapshots * Update snapshot Co-authored-by: Cristiano Belloni <cristiano.belloni@jpmorgan.com> Co-authored-by: Cristiano Belloni <cristiano-belloni@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cristiano-belloni
added a commit
that referenced
this pull request
May 12, 2022
* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Update packages/modular-scripts/src/addPackage.ts Co-authored-by: Steve King <steve@mydev.co> * Update packages/modular-scripts/src/serve.ts Co-authored-by: Steve King <steve@mydev.co> * Remove assertion * Use Object.create * Use map for importMap * Use paths to get the entrypoint file * Simplify index creation * Wording of add options Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com> Co-authored-by: Steve King <steve@mydev.co>
cristiano-belloni
added a commit
that referenced
this pull request
May 20, 2022
* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Extract resolutions from lockfile and use them to build esbuild * Extract resolutions from lockfile and use them to build Webpack * Write tests for resolutions * Fix tests * Create tender-shirts-turn.md * Update test snapshots * Update rewriteDependenciesPlugin.ts * Use resolution if no version * Use reactdom version if present * Merge api.ts Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com>
cristiano-belloni
added a commit
that referenced
this pull request
May 24, 2022
* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Extract resolutions from lockfile and use them to build esbuild * Extract resolutions from lockfile and use them to build Webpack * Write tests for resolutions * Fix tests * Add the analyze command * Add docs * Fix title in docs * Create lemon-rules-kick.md * Revert merged * Better docs * Update docs/commands/analyze.md Co-authored-by: Steve King <steve@mydev.co> * Use strip-ansi * Update lemon-rules-kick.md * Use explicit numbers in list Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com> Co-authored-by: Steve King <steve@mydev.co>
cristiano-belloni
added a commit
that referenced
this pull request
May 31, 2022
* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Write docs for ESM Views * Merge api.ts * Update esm views.md * Remove redundant micromatch link * Reformat docs * Mention resolutions * Fix grammar / content * Explain trampoline file * Additional review fixes * Apply suggestions from code review Co-authored-by: Steve King <steve@mydev.co> * Linting * content fix * Apply suggestions from code review Co-authored-by: Steve King <steve@mydev.co> * Lint * Hyphenate file names Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com> Co-authored-by: Steve King <steve@mydev.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the node engine range + consequently revert the dependabot upgrade of eslint-plugin-testing-library.