fix node-12 incompatible javascript by LukeSheard · Pull Request #1517 · jpmorganchase/modular

LukeSheard · 2022-03-28T11:13:19Z

No description provided.

changeset-bot · 2022-03-28T11:13:21Z

🦋 Changeset detected

Latest commit: 4f8b050

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
create-modular-react-app	Patch
modular-scripts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2022-03-28T11:27:55Z

Coverage increased (+0.04%) to 28.786% when pulling 4f8b050 on patch/fix-js-output into 985a2d7 on main.

benpryke · 2022-03-28T12:19:48Z

babel.config.js

        {
          targets: {
-            node: 'current',
+            // TODO: can we get this to read from package.json somehow..?


Q: Can you not read package.json and parse the engines.node field to find the smallest number?

benpryke · 2022-03-28T12:21:40Z

babel.config.js

-      },
+      '@babel/preset-typescript',
    ],
+    plugins: ['@babel/plugin-proposal-class-properties'],


Q: Why do we need to add this additional plugin on top of @babel/preset-typescript? Are there any more we need?

This reverts commit 22c2114.

* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Update snapshots * Remove alpha release artifacts * Update snapshots * Update snapshots * Update snapshot Co-authored-by: Cristiano Belloni <cristiano.belloni@jpmorgan.com> Co-authored-by: Cristiano Belloni <cristiano-belloni@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Update packages/modular-scripts/src/addPackage.ts Co-authored-by: Steve King <steve@mydev.co> * Update packages/modular-scripts/src/serve.ts Co-authored-by: Steve King <steve@mydev.co> * Remove assertion * Use Object.create * Use map for importMap * Use paths to get the entrypoint file * Simplify index creation * Wording of add options Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com> Co-authored-by: Steve King <steve@mydev.co>

* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Extract resolutions from lockfile and use them to build esbuild * Extract resolutions from lockfile and use them to build Webpack * Write tests for resolutions * Fix tests * Create tender-shirts-turn.md * Update test snapshots * Update rewriteDependenciesPlugin.ts * Use resolution if no version * Use reactdom version if present * Merge api.ts Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com>

* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Extract resolutions from lockfile and use them to build esbuild * Extract resolutions from lockfile and use them to build Webpack * Write tests for resolutions * Fix tests * Add the analyze command * Add docs * Fix title in docs * Create lemon-rules-kick.md * Revert merged * Better docs * Update docs/commands/analyze.md Co-authored-by: Steve King <steve@mydev.co> * Use strip-ansi * Update lemon-rules-kick.md * Use explicit numbers in list Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com> Co-authored-by: Steve King <steve@mydev.co>

* Bring webpack configuration to a valid (but not working) state * webpack build working * Remove sourcemap obsolete flag * Redo ForkTsCheckerWebpackPlugin conf * Fix stats type mismatch * start.js * dev server working but trying to typecheck node_modules * webpack start is working * Change css minimizer to remove deprecation * Remove diagnostics * Update snapshots * Support new version of minimize * Add explaining comment * Update yarn.lock * Update snapshots * Update all snapshots * Update snapshot hash * Add missing quotes * Remove unwanted media dist files * remove tsbuildinfo * Make test names decoupled from hashes * Update test snapshots * Create silver-dolphins-remember.md * Enter pre-release mode * Remove requireEnsure * Regenerate pre.json * remove workflow rule * Update pre.json * Update snapshots * Update build snapshots * Update browser versions * Version Packages (alpha-webpack5) * Revert "Revert engine range (#1518)" This reverts commit d896289. * Revert "fix node-12 incompatible javascript (#1517)" This reverts commit 22c2114. * Remove node 12 support * Add changeset * Add node 18 in CI * Revert "Add node 18 in CI" This reverts commit c40158b. * Hardcode node to v14 * support node 16 explicitly and run test workflow against target node versions * fix node versions so that tests run * Create dirty-mugs-double.md * fix node versions so that tests run and remove 15 since it's unsupported * Raise version to be compatible with eslint * Version Packages (alpha-webpack5) * Support for esm-view type in react scripts * Add esm-view into modular types * Better names for isView + activate esm-views in start * Update tests * Add tests and way of adding esm-view * Better comments/names * Add esm-view type * Add package modular-template-esm-view * Fix logger error * fix esm view tests * Fix app tests * Fix view tests * Fix build tests * Remove residual changelogs * Fix app node env tests * Fix WorkspaceInfo test * Create proud-starfishes-stare.md * Write docs for ESM Views * Merge api.ts * Update esm views.md * Remove redundant micromatch link * Reformat docs * Mention resolutions * Fix grammar / content * Explain trampoline file * Additional review fixes * Apply suggestions from code review Co-authored-by: Steve King <steve@mydev.co> * Linting * content fix * Apply suggestions from code review Co-authored-by: Steve King <steve@mydev.co> * Lint * Hyphenate file names Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Sheard <me@lukesheard.com> Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com> Co-authored-by: Steve King <steve@mydev.co>

fix node-12 incompatible javascript

2fcba18

Create thick-monkeys-kick.md

4f8b050

cristiano-belloni self-requested a review March 28, 2022 12:20

steveukx approved these changes Mar 28, 2022

View reviewed changes

cristiano-belloni approved these changes Mar 28, 2022

View reviewed changes

benpryke reviewed Mar 28, 2022

View reviewed changes

LukeSheard merged commit 22c2114 into main Mar 28, 2022

LukeSheard deleted the patch/fix-js-output branch March 28, 2022 12:26

github-actions bot mentioned this pull request Mar 28, 2022

Version Packages #1519

Merged

cristiano-belloni pushed a commit that referenced this pull request Apr 5, 2022

Revert "fix node-12 incompatible javascript (#1517)"

d2aacf6

This reverts commit 22c2114.

LukeSheard pushed a commit that referenced this pull request Apr 12, 2022

Revert "fix node-12 incompatible javascript (#1517)"

b81cbdf

This reverts commit 22c2114.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix node-12 incompatible javascript#1517

fix node-12 incompatible javascript#1517
LukeSheard merged 2 commits intomainfrom
patch/fix-js-output

LukeSheard commented Mar 28, 2022

Uh oh!

changeset-bot bot commented Mar 28, 2022 •

edited

Loading

Uh oh!

coveralls commented Mar 28, 2022 •

edited

Loading

Uh oh!

benpryke Mar 28, 2022 •

edited

Loading

Uh oh!

benpryke Mar 28, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

LukeSheard commented Mar 28, 2022

Uh oh!

changeset-bot bot commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coveralls commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benpryke Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benpryke Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-bot bot commented Mar 28, 2022 •

edited

Loading

coveralls commented Mar 28, 2022 •

edited

Loading

benpryke Mar 28, 2022 •

edited

Loading

benpryke Mar 28, 2022 •

edited

Loading