Remove service worker impl generation from workbox plugin.#1152
Merged
LukeSheard merged 2 commits intomainfrom Dec 6, 2021
Merged
Remove service worker impl generation from workbox plugin.#1152LukeSheard merged 2 commits intomainfrom
LukeSheard merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: bf4e399 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Merged
LukeSheard
added a commit
that referenced
this pull request
Dec 6, 2021
LukeSheard
added a commit
that referenced
this pull request
Jan 24, 2022
* replace babel with esbuild for package compilation * Add support for target as part of rollup transpilation * fix package.json * remove dist-cjs reference * Create mean-bobcats-attend.md * Bump tsconfig.json target to es2016 (#1154) * Remove service worker impl generation from workbox plugin. (#1152) * Simplify package.json scripts (#1155) * simplify package.json scripts * Update release.yml * fix up failing tests * Update output from builds * Update mean-bobcats-attend.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for the workbox plugin as we don't generate service workers by default and they are not important when it comes to our dynamic view loading architecture.