Skip to content

Replace babel with esbuild for package compilation#1150

Merged
LukeSheard merged 19 commits intomainfrom
feature/rollup-esbuild
Jan 24, 2022
Merged

Replace babel with esbuild for package compilation#1150
LukeSheard merged 19 commits intomainfrom
feature/rollup-esbuild

Conversation

@LukeSheard
Copy link
Contributor

This replaces the rollup-plugin-babel with rollup-plugin-esbuild when building libraries.

We generate the same target from the browserlists configuration for the repository so that output from libraries and applications support the same browser range as each other. This also reduces the overhead of installation by removing a lot of the babel dependency tree that we had previously.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2021

🦋 Changeset detected

Latest commit: 7c5cd84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Dec 6, 2021

Coverage Status

Coverage decreased (-0.009%) to 28.132% when pulling 7c5cd84 on feature/rollup-esbuild into 375a66d on main.

@LukeSheard LukeSheard marked this pull request as ready for review December 6, 2021 19:35
Copy link
Contributor

@cristiano-belloni cristiano-belloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@cristiano-belloni cristiano-belloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cristiano-belloni cristiano-belloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had approved it, but it seems tests are failing

@LukeSheard LukeSheard merged commit 8b0826e into main Jan 24, 2022
@LukeSheard LukeSheard deleted the feature/rollup-esbuild branch January 24, 2022 11:21
@github-actions github-actions bot mentioned this pull request Jan 24, 2022
This was referenced Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants