Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Feb 26, 2025

Pull Request for Issue # .

Summary of Changes

  • Remove the really outdated (and not used since 4.0) chosen.js
  • Remove the old Tags scripts that used it
  • cleanup the build tools
  • Cleanup serachtools and the cassiopeia references to chosen js and css

Testing Instructions

Chosen is not used anywhere in the J4/5 so just checking that the filters in the list view of articles still works is a successful test (the filters had some code removed)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Feb 26, 2025
@Fedik Fedik added the Removal Removes functionality label Feb 27, 2025
@Fedik
Copy link
Member

Fedik commented Feb 27, 2025

I have tested this item ✅ successfully on 77d8b3e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

@brianteeman
Copy link
Contributor

Remove the old Tags scripts that used it

where

@dgrammatiko
Copy link
Contributor Author

@brianteeman I guess my comment is confusing, I mean there are 2 files (build/media_source/legacy/js/ajax-chosen.es5.js, build/media_source/legacy/js/joomla-chosen.es5.js) that depend on chosen and these are removed. Joomla 4+ doesn't use anywhere chosen thus chosen and the 2 files are removed. Also cleaned up any scripts that had chosen references

@brianteeman
Copy link
Contributor

I assumed you referred to \build\media_source\system\js\fields\tag.es5.js which appears to use chosen and is not touched by this PR

@dgrammatiko
Copy link
Contributor Author

I assumed you referred to \build\media_source\system\js\fields\tag.es5.js

That's the other part of the J3 tags that obviously I missed! Thanks

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7b801be

real tests produce real results


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

@laoneo laoneo added b/c break This item changes the behavior in an incompatible why. HEADS UP and removed Removal Removes functionality labels Feb 28, 2025
@dgrammatiko
Copy link
Contributor Author

@softforge any interest here?

@brianteeman
Copy link
Contributor

would be good to get this merged

@Fedik
Copy link
Member

Fedik commented Aug 15, 2025

I have tested this item ✅ successfully on 42f6b65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

@Fedik
Copy link
Member

Fedik commented Aug 15, 2025

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 15, 2025
@softforge softforge added this to the Joomla! 6.0.0 milestone Aug 16, 2025
@softforge softforge merged commit 433bacf into joomla:6.0-dev Aug 16, 2025
30 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2025
@softforge
Copy link
Contributor

Thank you to all involved, good job

@dgrammatiko dgrammatiko deleted the 6.0-dev/remove-chosen branch August 16, 2025 12:28
@richard67
Copy link
Member

@dgrammatiko @Fedik Can the media/vendor/chosen folder be removed on update? Or do we have to keep it? Am asking because working on the deleted files and folders lists in script.php.

@brianteeman
Copy link
Contributor

@richard67 not only "can it" but "it must be removed" otherwise we are leaving files behind that might be exposed as being vulnerable in the future and we wouldnt do anything about it because we wouldnt know

@dgrammatiko
Copy link
Contributor Author

We should delete it

@richard67
Copy link
Member

For deleting obsolete files and folders on update see #45928 .

@ramalama
Copy link

ramalama commented Dec 2, 2025

The removal is not complete and not documented in migrations docs. See https://issues.joomla.org/tracker/joomla-cms/46526


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants