-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Remove chosen #45018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Remove chosen #45018
Conversation
|
I have tested this item ✅ successfully on 77d8b3e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018. |
where |
|
@brianteeman I guess my comment is confusing, I mean there are 2 files (build/media_source/legacy/js/ajax-chosen.es5.js, build/media_source/legacy/js/joomla-chosen.es5.js) that depend on chosen and these are removed. Joomla 4+ doesn't use anywhere chosen thus chosen and the 2 files are removed. Also cleaned up any scripts that had chosen references |
|
I assumed you referred to |
That's the other part of the J3 tags that obviously I missed! Thanks |
|
I have tested this item ✅ successfully on 7b801be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018. |
|
@softforge any interest here? |
|
would be good to get this merged |
|
I have tested this item ✅ successfully on 42f6b65 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018. |
|
r2c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018. |
|
Thank you to all involved, good job |
|
@dgrammatiko @Fedik Can the |
|
@richard67 not only "can it" but "it must be removed" otherwise we are leaving files behind that might be exposed as being vulnerable in the future and we wouldnt do anything about it because we wouldnt know |
|
We should delete it |
|
For deleting obsolete files and folders on update see #45928 . |
|
The removal is not complete and not documented in migrations docs. See https://issues.joomla.org/tracker/joomla-cms/46526 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45018. |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Chosen is not used anywhere in the J4/5 so just checking that the filters in the list view of articles still works is a successful test (the filters had some code removed)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed