Skip to content

[5.2] superfluous space deleted, alpha sorting and wording for pr #39878#44753

Merged
pe7er merged 8 commits intojoomla:5.2-devfrom
tecpromotion:fix-pr-39878
Jan 25, 2025
Merged

[5.2] superfluous space deleted, alpha sorting and wording for pr #39878#44753
pe7er merged 8 commits intojoomla:5.2-devfrom
tecpromotion:fix-pr-39878

Conversation

@tecpromotion
Copy link
Contributor

@tecpromotion tecpromotion commented Jan 19, 2025

Pull Request for PR #39878.

Summary of Changes

PR [5.2] Error handling while create folder in media manager new pr #39878 adds three new strings.
In the first sentence, a space was added at the end. This PR deletes the space.

I would also be in favour of full stops at the end, but that should be of secondary importance for now.

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists "

Expected result AFTER applying this Pull Request

COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Jan 19, 2025
@brianteeman
Copy link
Contributor

Please add that missing full stop. Our style guide requests sentences and with a .

@richard67
Copy link
Member

richard67 commented Jan 19, 2025

Hmm, but then it might sense to add the missing full stop also to the COM_MEDIA_CREATE_NEW_FOLDER_RELATIVE_PATH_ERROR and COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER strings just below.

COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER="Only Alphanumeric ,underscore(_),hyphen(-) and peroid(.) are allowed"
COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists."
COM_MEDIA_CREATE_NEW_FOLDER_RELATIVE_PATH_ERROR="Use of relative paths not permitted."
COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER="Only Alphanumeric ,underscore(_),hyphen(-) and peroid(.) are allowed."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo and extra space and remove symbols.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo and extra space and remove symbols.

By symbols you mean the () or the characters _ - and . ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER="Only alphanumeric, underscore, hyphen and period are allowed."

or similar to:

COM_TEMPLATES_INVALID_FOLDER_NAME="Invalid folder name. Please choose a folder name with a-z, A-Z, 0-9, - and _."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this wording possibly be used?

COM_TEMPLATES_ERROR_INVALID_TEMPLATE_NAME="Invalid template name. Please use only letters, numbers and underscores."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer

COM_TEMPLATES_INVALID_FOLDER_NAME="Invalid folder name. Please choose a folder name with a-z, A-Z, 0-9, - and _."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A period is also allowed.

@tecpromotion tecpromotion changed the title [5.2] superfluous space deleted [5.2] superfluous space deleted, alpha sorting and wording for pr #39878 Jan 19, 2025
@tecpromotion tecpromotion requested a review from QuyTon January 20, 2025 08:13
@QuyTon
Copy link
Contributor

QuyTon commented Jan 20, 2025

Let's keep it shorter to not wrap:

39878

Suggested change:

39878-proposed

@brianteeman
Copy link
Contributor

Let's keep it shorter to not wrap:

Remember that only applies to english

@tecpromotion
Copy link
Contributor Author

Let's keep it shorter to not wrap:

Remember that only applies to english

Do you have a good idea?

@brianteeman
Copy link
Contributor

The suggested text is an improvement by @QuyTon. I just wanted to point out that you cant assume that it wont wrap

@tecpromotion
Copy link
Contributor Author

The suggested text is an improvement by @QuyTon. I just wanted to point out that you cant assume that it wont wrap

I appreciate the suggestion from @QuyTon and your comment also makes sense. If you don't have any other suggestions for the time being, I'll adopt this and everyone should be aware that, depending on the translation and language, a change can happen here.

@QuyTon
Copy link
Contributor

QuyTon commented Jan 24, 2025

I have tested this item ✅ successfully on e2e3b8e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753.

1 similar comment
@ghost
Copy link

ghost commented Jan 24, 2025

I have tested this item ✅ successfully on e2e3b8e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753.

@QuyTon
Copy link
Contributor

QuyTon commented Jan 24, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 24, 2025
@pe7er pe7er self-assigned this Jan 24, 2025
@pe7er pe7er enabled auto-merge (squash) January 25, 2025 16:39
@pe7er pe7er added this to the Joomla! 5.2.4 milestone Jan 25, 2025
@pe7er pe7er merged commit 9956abc into joomla:5.2-dev Jan 25, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 25, 2025
@pe7er
Copy link
Contributor

pe7er commented Jan 25, 2025

Thanks @tecpromotion !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants