[5.2] superfluous space deleted, alpha sorting and wording for pr #39878#44753
[5.2] superfluous space deleted, alpha sorting and wording for pr #39878#44753pe7er merged 8 commits intojoomla:5.2-devfrom
Conversation
|
Please add that missing full stop. Our style guide requests sentences and with a . |
|
Hmm, but then it might sense to add the missing full stop also to the |
| COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER="Only Alphanumeric ,underscore(_),hyphen(-) and peroid(.) are allowed" | ||
| COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists." | ||
| COM_MEDIA_CREATE_NEW_FOLDER_RELATIVE_PATH_ERROR="Use of relative paths not permitted." | ||
| COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER="Only Alphanumeric ,underscore(_),hyphen(-) and peroid(.) are allowed." |
There was a problem hiding this comment.
Please fix typo and extra space and remove symbols.
There was a problem hiding this comment.
Please fix typo and extra space and remove symbols.
By symbols you mean the () or the characters _ - and . ?
There was a problem hiding this comment.
COM_MEDIA_CREATE_NEW_FOLDER_UNEXPECTED_CHARACTER="Only alphanumeric, underscore, hyphen and period are allowed."
or similar to:
COM_TEMPLATES_INVALID_FOLDER_NAME="Invalid folder name. Please choose a folder name with a-z, A-Z, 0-9, - and _."
There was a problem hiding this comment.
Could this wording possibly be used?
There was a problem hiding this comment.
I prefer
Remember that only applies to english |
Do you have a good idea? |
|
The suggested text is an improvement by @QuyTon. I just wanted to point out that you cant assume that it wont wrap |
I appreciate the suggestion from @QuyTon and your comment also makes sense. If you don't have any other suggestions for the time being, I'll adopt this and everyone should be aware that, depending on the translation and language, a change can happen here. |
|
I have tested this item ✅ successfully on e2e3b8e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753. |
1 similar comment
|
I have tested this item ✅ successfully on e2e3b8e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44753. |
|
Thanks @tecpromotion ! |
joomla/joomla-cms#44658 + joomla/joomla-cms#44712 - (только для др. пакетов) joomla/joomla-cms#39878 + joomla/joomla-cms#38536 + joomla/joomla-cms#36719 + joomla/joomla-cms#44753 + joomla/joomla-cms#44709 + joomla/joomla-cms#44793 - (только для en-GB)


Pull Request for PR #39878.
Summary of Changes
PR [5.2] Error handling while create folder in media manager new pr #39878 adds three new strings.
In the first sentence, a space was added at the end. This PR deletes the space.
I would also be in favour of full stops at the end, but that should be of secondary importance for now.
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists "Expected result AFTER applying this Pull Request
COM_MEDIA_CREATE_NEW_FOLDER_EXISTING_FOLDER_ERROR="Folder or file name already exists"Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed