[5.2] MediaManager: improve error handling

[Fedik]

Pull Request for Issue #38068 and #38530 .

Summary of Changes

Improve error handling in MediaManager

Testing Instructions

Apply patch. Run npm install.
Try upload something not allowed in to mediamanager.

Actual result BEFORE applying this Pull Request

General error Unable to upload file.

Expected result AFTER applying this Pull Request

General error Unable to upload file.
Then multiple detailed errors:
Or Illegal mime type detected or This file type is not supported (depend from medimanager config)
Or for svg: The file looks suspicious, therefore cannot be uploaded

Documentation Changes Required

nope

@brianteeman please review an updated string.

[laoneo]

Nice one as it will catch on every request the error messages.

[obuisard]

Thank you for providing a better solution!

[brianteeman]

even better would be to display the error message from the svgsanitizer which explains exactly why the file was rejected

[obuisard]

I have added documentation about uploading SVG files. You can find it at https://docs.joomla.org/J4.x:Media:_Uploading_SVG_files. It may need refining and additional content. You are welcome to pitch in, thank you!

[brianteeman]

IT does what it says but I wonder why we have the two messages. The second one makes the first one redundant?

[Fedik]

The script render all messages that was sent from PHP backend.
In your example, I guess the first one comes from a controller, and second one from a validator.

[brianteeman]

I have tested this item ✅ successfully on b5feda2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38536.}

[Fedik]

Before the fix, the script was rendered only first message, and rest were ignored.

[joomdonation]

In your example, I guess the first one comes from a controller, and second one from a validator

The first message is from the Exception https://github.com/joomla/joomla-cms/blob/4.2-dev/plugins/filesystem/local/src/Adapter/LocalAdapter.php#L772 , additional messages are Joomla system messages generated by calling $app->enqueueMessage from canUpload from MediaHelper https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Helper/MediaHelper.php#L200

Still the first error message is redundant as Brian said. Is it OK to make the Exception https://github.com/joomla/joomla-cms/blob/4.2-dev/plugins/filesystem/local/src/Adapter/LocalAdapter.php#L772 with empty message, and have the Joomla system messages rendered for this case ? It is kind of workaround but more user friendly.

[Fedik]

Is it OK to make the Exception with empty message

I do not think.
I think the root issue that $helper->canUpload() should return boolean and cannot throw an exception, so someone decided to put all in to $app->enqueueMessage . Not perfect, but working.

[joomdonation]

I have tested this item ✅ successfully on b5feda2

Not perfect but work.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38536.}

[joomdonation]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38536.}

[brianteeman]

@AmyKrizanWang please do not update your comment. It is nothing to do with this issue.

[HLeithner]

This pull request has been automatically rebased to 4.3-dev.

[HLeithner]

This pull request has been automatically rebased to 4.4-dev.

[AmyKrizanWang]

@AmyKrizanWang please do not update your comment. It is nothing to do with this issue.

comment removed

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[pe7er]

I have tested this item ✅ successfully on 2e13c16

Before PR

After PR (and recompiling with npm ci)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38536.}

[MacJoom]

I have tested this item ✅ successfully on 8b01df6

Upload of a suspicous svg failed with the new messages. Ordinary svg worked

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38536.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38536.}

[Hackwar]

Thank you!