[5.2] Adjust the links for more details within the HTTP Header Plugin #44658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on only and the generad description similiar to the other sites
brianteeman
reviewed
Dec 22, 2024
Co-authored-by: Brian Teeman <brian@teeman.net>
|
I have tested this item ✅ successfully on f906b5a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44658. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on f906b5a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44658. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44658. |
Member
|
Thank you! |
4 tasks
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Feb 12, 2025
joomla/joomla-cms#44658 + joomla/joomla-cms#44712 - (только для др. пакетов) joomla/joomla-cms#39878 + joomla/joomla-cms#38536 + joomla/joomla-cms#36719 + joomla/joomla-cms#44753 + joomla/joomla-cms#44709 + joomla/joomla-cms#44793 - (только для en-GB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adjust the links for more details within the HTTP Header Plugin
Testing Instructions
Check the Configuration Options for the Strict-Transport-Security within the plugin before and after the patch
Actual result BEFORE applying this Pull Request
The hsts preload list is linked from the first option which is not quite correct as that site is only relevant when the preload option is set.
Expected result AFTER applying this Pull Request
The main header links to the mozilla MDN and the hsts preload page is linked from the preload setting only which makes more sense.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed