Skip to content

Conversation

@LadySolveig
Copy link
Contributor

@LadySolveig LadySolveig commented Nov 21, 2024

Pull Request for Issue # .

Summary of Changes

This PR adds the js-grid-item-is-checked class and remove onClick in the HtmlHelper for Grid as it was originally prepared in the script.

target.querySelectorAll('.js-grid-item-is-checked').forEach((element) => element.addEventListener('click', applyIsChecked));

Testing Instructions

  • install blog sample data
    BACKEND
  • go to articles list view
  • try out if you can mark single articles bei checkbox and by clicking on the row
  • try out if you can mark multiple articles
  • try out if you can select and deselect all articles
  • try if you can mark articles and use the batch processes
    FRONTEND
  1. go to Sample Layouts -> Category List
    • check if ordering works as expected
      grafik
  2. create menu item with menu item type -> List All Tags
    • check if filter works as expected
  3. create menu item with menu item type -> Featured Contacts
    • check if ordering works as expected

Install this PR
Do the same again.

Actual result BEFORE applying this Pull Request

All should work.

Expected result AFTER applying this Pull Request

All should work as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: WIP

  • No documentation changes for manual.joomla.org needed

@LadySolveig LadySolveig marked this pull request as ready for review November 21, 2024 13:55
@Quy
Copy link
Contributor

Quy commented Nov 21, 2024

I have tested this item ✅ successfully on 5b16e75


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44501.

@dgrammatiko
Copy link
Contributor

FWIW I had to revert this some time ago as it broke 3rd PD code: #40192
But would be cool to have CSP strict OOTB at some point

@LadySolveig LadySolveig marked this pull request as draft November 22, 2024 14:14
@LadySolveig LadySolveig changed the base branch from 5.3-dev to 6.0-dev February 9, 2025 15:56
@joomla-cms-bot joomla-cms-bot added Composer Dependency Changed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev Unit/System Tests labels Feb 9, 2025
@LadySolveig LadySolveig changed the title [5.3] Add the js-grid-item-is-checked class and remove onClick HtmlHelper Grid [6.0] Add the js-grid-item-is-checked class and remove onClick HtmlHelper Grid Feb 9, 2025
@Bodge-IT
Copy link
Contributor

Hi @LadySolveig, how can we help you to get this over the line?

@bembelimen
Copy link
Contributor

Hi @LadySolveig, how can we help you to get this over the line?

image

I guess by fixing the conflict and make a PR against @LadySolveig repo :)

@joomla-cms-bot joomla-cms-bot removed Unit/System Tests Composer Dependency Changed NPM Resource Changed This Pull Request can't be tested by Patchtester labels Feb 12, 2025
@LadySolveig
Copy link
Contributor Author

Thank you @Bodge-IT for your interest 💚
After the very helpful hint from @dgrammatiko , I thought the PR would probably be better off in 6.0.
I have tested myself whether there is still a problem with sorting or filtering in the frontend. I have not been able to detect any more problems, but I have also included it in the testing instructions.
After the rebase I just waited for your upmerge to solve the remaining conflicts.

The note on the change in manual.joomla.org is still missing - I will deliver it soon and then gladly change the status to ready to review. 😊

@rdeutz rdeutz removed the PR-5.3-dev label Mar 5, 2025
@LadySolveig LadySolveig force-pushed the 5.3/patch/js-grid-item-is-checked branch from 666318b to 4f03df9 Compare August 14, 2025 11:25
@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label Aug 14, 2025
@LadySolveig LadySolveig deleted the 5.3/patch/js-grid-item-is-checked branch October 30, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.