Skip to content

Conversation

@LadySolveig
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR adds the js-grid-item-is-checked class and remove onClick in the HtmlHelper for Grid as it was originally prepared in the script.

target.querySelectorAll('.js-grid-item-is-checked').forEach((element) => element.addEventListener('click', applyIsChecked));

Additional Note:

Follow up for PR #44501 as I unfortunately messed up my branch when attempting to resolve a conflict.
Important hint from @dgrammatiko #44501 (comment)

Testing Instructions

  • install blog sample data
    BACKEND
  • go to articles list view
  • try out if you can mark single articles bei checkbox and by clicking on the row
  • try out if you can mark multiple articles
  • try out if you can select and deselect all articles
  • try if you can mark articles and use the batch processes
    FRONTEND
  1. go to Sample Layouts -> Category List
    • check if ordering works as expected
      grafik
  2. create menu item with menu item type -> List All Tags
    • check if filter works as expected
  3. create menu item with menu item type -> Featured Contacts
    • check if ordering works as expected

Install this PR
Do the same again.

Actual result BEFORE applying this Pull Request

All should work.

Expected result AFTER applying this Pull Request

All should work as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: WIP

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 77a36e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

@brianteeman
Copy link
Contributor

Does this also solve #45770


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 77a36e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

@alikon
Copy link
Contributor

alikon commented Aug 15, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45910.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 15, 2025
@dgrammatiko
Copy link
Contributor

dgrammatiko commented Aug 15, 2025

Does this also solve #45770

Not the onclick="Joomla.tableOrdering, these are inline scripts on another file: libraries/src/HTML/Helpers/Grid.php

@softforge softforge added this to the Joomla! 6.0.0 milestone Aug 16, 2025
@softforge softforge merged commit 4b976fc into joomla:6.0-dev Aug 16, 2025
30 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2025
@LadySolveig LadySolveig deleted the 6.0/patch/js-grid-item-is-checked branch October 30, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants