Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Mar 25, 2023

Pull Request for Issue #39730 (comment) .

Summary of Changes

  • Revert the CSP removal of inline scripts for the Grid.php

Testing Instructions

Check that in the \Home\Sample Layouts\Category List front end route, the table could sort against any of the table headers

Actual result BEFORE applying this Pull Request

Nothing

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@dgrammatiko dgrammatiko changed the title [4.3] Front End sorting [4.3] Revert CSP related changes in Grid.php (back to inline scripts) Mar 25, 2023
@Quy
Copy link
Contributor

Quy commented Mar 25, 2023

I have tested this item ✅ successfully on 5f4f28c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40192.

@joeforjoomla
Copy link
Contributor

I have tested this item ✅ successfully on 5f4f28c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40192.

1 similar comment
@joeforjoomla
Copy link
Contributor

I have tested this item ✅ successfully on 5f4f28c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40192.

@Quy
Copy link
Contributor

Quy commented Mar 26, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40192.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 26, 2023
@obuisard obuisard merged commit 52660a6 into joomla:4.3-dev Mar 26, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 26, 2023
@obuisard
Copy link
Contributor

Thank you Dimitris @dgrammatiko! Thanks all for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants