[5.3] Deprecate AbstractView::get()#44162
Merged
laoneo merged 4 commits intojoomla:5.3-devfrom Oct 5, 2024
Merged
Conversation
4 tasks
laoneo
approved these changes
Oct 1, 2024
Member
|
Can you make here the manual entry as well? |
Member
Author
|
The PR for manual.joomla.org has been created and linked. The question is how to get all the occurences of this in docs.joomla.org removed? Since there are plans on changing docs.joomla.org, should we change it there now? |
Member
Author
|
I added a deprecation trigger to the method. |
Quy
reviewed
Oct 3, 2024
laoneo
reviewed
Oct 4, 2024
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Member
|
Thanks! |
brbrbr
added a commit
to brbrbr/Blc
that referenced
this pull request
Oct 8, 2024
brbrbr
added a commit
to brbrbr/Blc
that referenced
this pull request
Oct 8, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In a time far far away, someone thought it might be a good idea to introduce an indirection in the view to get the data from the model by adding
AbstractView::get(), which retrieves the model and then runsget<Parameter>()on the model. This removes any chance of typehinting, etc. and makes everything unnecessarily complex, so we are deprecating this method with this PR.The new way hence forth shall be for example:
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Removing AbstractView::get() Manual#318
No documentation changes for manual.joomla.org needed