Skip to content

[5.3] Deprecate AbstractView::get() #44162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laoneo merged 4 commits into from
Oct 5, 2024
Merged

[5.3] Deprecate AbstractView::get() #44162

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
987555c
Deprecate AbstractView::get()
Hackwar Sep 30, 2024
49e52ad
Adding deprecation trigger to AbstractView::get()
Hackwar Oct 3, 2024
0e2603b
Update libraries/src/MVC/View/AbstractView.php
Hackwar Oct 4, 2024
e00e95b
Merge branch '5.3-dev' into 5.3-view-get
Hackwar Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions libraries/src/MVC/View/AbstractView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,21 @@ abstract public function display($tpl = null);
* @return mixed The return value of the method
*
* @since 3.0
*
* @deprecated __DEPLOY_VERSION__ will be removed in 7.0.
* Retrieve the model with $model = $this->getModel(); and call the methods
* to the model directly, e.g. $model->getItems() instead of $this->get('Items').
*/
public function get($property, $default = null)
{
trigger_deprecation(
'joomla/mvc/view',
'5.3',
'The %s() method is deprecated and will be removed in 7.0. use $model = $this->getModel();
$this->items = $model->getItems(); instead',
__METHOD__
);

// If $model is null we use the default model
if ($default === null) {
$model = $this->_defaultModel;
Expand Down