Added plugin event triggers to the new mod_articles module#44132
Merged
Hackwar merged 7 commits intojoomla:5.2-devfrom Sep 27, 2024
RickR2H:plugin-events
Merged
Added plugin event triggers to the new mod_articles module#44132Hackwar merged 7 commits intojoomla:5.2-devfrom RickR2H:plugin-events
Hackwar merged 7 commits intojoomla:5.2-devfrom
RickR2H:plugin-events
Conversation
richard67
reviewed
Sep 24, 2024
Fedik
reviewed
Sep 25, 2024
Contributor
|
The module parameters are also used in the plugin with demo data. We probably need to make changes in file plugins/sampledata/blog/src/Extension/Blog.php, because demo data creates 3 modules of type ARTICLES after installation. UPD |
Contributor
|
I have tested this item ✅ successfully on a5a2329 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44132. |
1 similar comment
Member
|
I have tested this item ✅ successfully on a5a2329 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44132. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44132. |
Member
|
Thanks for your contribution @RickR2H |
4 tasks
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Oct 1, 2024
joomla/joomla-cms#44106 - (только для en-GB) joomla/joomla-cms#44075 + joomla/joomla-cms#44093 + joomla/joomla-cms#43694 + joomla/joomla-cms#44082 + joomla/joomla-cms#44110 - (только для en-GB) joomla/joomla-cms#44111 + joomla/joomla-cms#44105 + joomla/joomla-cms#44146 - (только для др. пакетов) joomla/joomla-cms#44142 + joomla/joomla-cms#44127 - (только для en-GB) joomla/joomla-cms#44132 + joomla/joomla-cms#44137 + joomla/joomla-cms#44145 +
4 tasks
Fedik
reviewed
Oct 2, 2024
| PluginHelper::importPlugin('content', null, true, $dispatcher); | ||
|
|
||
| $contentEventArguments = [ | ||
| 'context' => 'com_content.article', |
Member
There was a problem hiding this comment.
This was merged with wrong context, what happened? 😄
Member
Author
There was a problem hiding this comment.
Adding the mod_articles context will not load the custom fields. It needs to go through com_content or else information will be missing. I didn't feel like change plugin events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
With #43738 a new articles module is added. This new module mod_articles module has no option to trigger the plugin events. In the mod_articles_news this options was present. This PR adds the option to this module.
Testing Instructions
Actual result BEFORE applying this Pull Request
No option to trigger plugin events.
Expected result AFTER applying this Pull Request
Plugin events afterDisplayTitle, beforeDisplayContent and afterDisplayContent are triggered for each article.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed