Articles Module: (Re)Introduced dynamic mode as on mod_articles_category#44145
Merged
Hackwar merged 5 commits intojoomla:5.2-devfrom Sep 28, 2024
Merged
Articles Module: (Re)Introduced dynamic mode as on mod_articles_category#44145Hackwar merged 5 commits intojoomla:5.2-devfrom
Hackwar merged 5 commits intojoomla:5.2-devfrom
Conversation
brianteeman
reviewed
Sep 26, 2024
Quy
reviewed
Sep 26, 2024
Contributor
|
Sorry, I wrote about the need to change the demo data plugin, but I didn't notice that it was already done. |
Member
|
I have tested this item ✅ successfully on 28cc184 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145. |
Contributor
|
I have tested this item ✅ successfully on 28cc184 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145. |
Quy
reviewed
Sep 28, 2024
Contributor
|
I thought we were in a language freeze for 5.2? |
Member
|
Yes, we are. And I'm unhappy with all of this, but the alternative is that we revert the whole articles module. |
Co-authored-by: Quy <quy@nomonkeybiz.com>
Member
|
Thank you for your contribution @drmenzelit! |
Contributor
No - the alternative was to add dynamic mode as a new feature in a future release. There is/was zero urgency at all to merge this |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Oct 1, 2024
joomla/joomla-cms#44106 - (только для en-GB) joomla/joomla-cms#44075 + joomla/joomla-cms#44093 + joomla/joomla-cms#43694 + joomla/joomla-cms#44082 + joomla/joomla-cms#44110 - (только для en-GB) joomla/joomla-cms#44111 + joomla/joomla-cms#44105 + joomla/joomla-cms#44146 - (только для др. пакетов) joomla/joomla-cms#44142 + joomla/joomla-cms#44127 - (только для en-GB) joomla/joomla-cms#44132 + joomla/joomla-cms#44137 + joomla/joomla-cms#44145 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Added the option for dynamic mode as it was in mod_articles_category
Testing Instructions
Create a module selecting dynamic mode. Create some menu items for different categories and check if the module display the articles of the category dynamically
Inline help:
Actual result BEFORE applying this Pull Request
No dynamic mode present
Expected result AFTER applying this Pull Request
The module display a list of articles depending on the category from the menu item
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed