Skip to content

[5.2-RC] mod_articles : show introtext not working#44179

Closed
conseilgouz wants to merge 1 commit intojoomla:5.2-devfrom
conseilgouz:mod_articles_show_introtext
Closed

[5.2-RC] mod_articles : show introtext not working#44179
conseilgouz wants to merge 1 commit intojoomla:5.2-devfrom
conseilgouz:mod_articles_show_introtext

Conversation

@conseilgouz
Copy link
Contributor

Mod_Articles : if show introtext parameter is set with an introtext limit greater than 0, a wrong value is displayed in the module.

Summary of Changes

In ArticlesHelper.php, show_introtext fills up displayIntrotext field (lines 362 to 373), but default_items.php displays introtext field (line 107).

Testing Instructions

In Articles module, set IntroText parameter to Show and set IntroText Limit to any non-zero value.

Actual result BEFORE applying this Pull Request

Articles module shows full article

Expected result AFTER applying this Pull Request

Articles module shows truncated articles to the defined limit.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ghost
Copy link

ghost commented Oct 2, 2024

@conseilgouz Can you add [5.2] to the title so user don't have to open the Pull Request to know which branche it is for?

@conseilgouz conseilgouz changed the title mod_articles : show introtext not working [5.2] mod_articles : show introtext not working Oct 2, 2024
@conseilgouz conseilgouz changed the title [5.2] mod_articles : show introtext not working [5.2-RC] mod_articles : show introtext not working Oct 2, 2024
@drmenzelit
Copy link
Contributor

#44132 introduced the wrong line ... it was correct before...

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 7a9b13e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179.

1 similar comment
@RickR2H
Copy link
Member

RickR2H commented Oct 2, 2024

I have tested this item ✅ successfully on 7a9b13e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179.

@RickR2H
Copy link
Member

RickR2H commented Oct 2, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 2, 2024
@conseilgouz conseilgouz closed this Oct 4, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 4, 2024
@conseilgouz conseilgouz deleted the mod_articles_show_introtext branch October 4, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments