[5.2-RC] mod_articles : show introtext not working#44179
Closed
conseilgouz wants to merge 1 commit intojoomla:5.2-devfrom
conseilgouz:mod_articles_show_introtext
Closed
[5.2-RC] mod_articles : show introtext not working#44179conseilgouz wants to merge 1 commit intojoomla:5.2-devfrom conseilgouz:mod_articles_show_introtext
conseilgouz wants to merge 1 commit intojoomla:5.2-devfrom
conseilgouz:mod_articles_show_introtext
Conversation
|
@conseilgouz Can you add |
Contributor
|
#44132 introduced the wrong line ... it was correct before... |
Contributor
|
I have tested this item ✅ successfully on 7a9b13e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 7a9b13e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179. |
This was referenced Oct 2, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mod_Articles : if show introtext parameter is set with an introtext limit greater than 0, a wrong value is displayed in the module.
Summary of Changes
In ArticlesHelper.php, show_introtext fills up displayIntrotext field (lines 362 to 373), but default_items.php displays introtext field (line 107).
Testing Instructions
In Articles module, set IntroText parameter to Show and set IntroText Limit to any non-zero value.
Actual result BEFORE applying this Pull Request
Articles module shows full article
Expected result AFTER applying this Pull Request
Articles module shows truncated articles to the defined limit.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed