Skip to content

[5.3] [Events] Use event classes for User plugins#43427

Merged
laoneo merged 10 commits intojoomla:5.3-devfrom
Fedik:plg-event-user
Feb 5, 2025
Merged

[5.3] [Events] Use event classes for User plugins#43427
laoneo merged 10 commits intojoomla:5.3-devfrom
Fedik:plg-event-user

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented May 4, 2024

Pull Request for Issue # .

Summary of Changes

Update user plugins to use SubscriberInterface and an event classes.

Testing Instructions

Check following user plugins should work as before:

contactcreator
joomla
profile
terms
token

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

References:

@Fedik Fedik added the Feature label May 4, 2024
@Fedik Fedik marked this pull request as draft May 5, 2024 07:43
@richard67
Copy link
Member

Drone failure is not related to this PR.

@Fedik Fedik marked this pull request as ready for review June 2, 2024 12:23
LadySolveig and others added 2 commits July 17, 2024 17:06
@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2][Events] Use event classes for User plugins [5.3] [Events] Use event classes for User plugins Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
@joomdonation
Copy link
Contributor

I reviewed the code and doing real test (Login, creating, changing user status, delete user.....), all still work well. So we have a successful test from me (after the tiny change suggested above).

@laoneo
Copy link
Member

laoneo commented Feb 5, 2025

Good will merge it and then you can make a new pr. Thanks for helping out.

@laoneo laoneo merged commit 55b56ec into joomla:5.3-dev Feb 5, 2025
3 checks passed
@laoneo laoneo added this to the Joomla! 5.3.0 milestone Feb 5, 2025
@joomdonation
Copy link
Contributor

Good will merge it and then you can make a new pr. Thanks for helping out.

PR #44820 created.

@Fedik Fedik deleted the plg-event-user branch February 5, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants