[5.3] Remove useless return statement#44820
Merged
laoneo merged 1 commit intojoomla:5.3-devfrom Feb 5, 2025
Merged
Conversation
4 tasks
laoneo
reviewed
Feb 5, 2025
Member
laoneo
left a comment
laoneo
left a comment
There was a problem hiding this comment.
Should we not just return here?
Contributor
Author
No, this statement is at the end of method, so adding return; here is useless. |
Member
|
Ah now I see it, thought it is at the end of an "if" block. |
Member
|
Thanks! |
Contributor
Author
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Follow up for the merged PR #43427 . Remove the
return true;statement because the method should havevoidreturn typeTesting Instructions
Can be merged by review as discussed in the PR. Ping @laoneo
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works