[5.0][Events] User event classes#41317
Merged
HLeithner merged 110 commits intojoomla:5.0-devfrom Aug 21, 2023
Merged
Conversation
This reverts commit d786b07.
Conflicts: components/com_content/src/View/Article/HtmlView.php libraries/src/Event/Content/ContentEvent.php libraries/src/Event/CoreEventAware.php libraries/src/HTML/Helpers/Content.php libraries/src/MVC/Controller/FormController.php libraries/src/MVC/Model/AdminModel.php libraries/src/MVC/Model/FormBehaviorTrait.php libraries/src/MVC/Model/FormModel.php
Conflicts: libraries/src/Event/CoreEventAware.php
Conflicts: libraries/src/Event/CoreEventAware.php
Member
|
thanks |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Implementing Event classes for User events.
The pr depend from #41226
Affected events:
Following events uses generic classes from
Joomla\Event\Modelfrom #41226:Note:
Event
onUserAuthenticateis untoched, because it is not an event, but callback. If we want to make it as event then we have to deprecate this one and introduce new oneonUserAuthenticate2.Testing Instructions
Apply patch.
Try add/edit/delete User, login, logout, use webauthn.
Add/edit/delete User group.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: