Conversation
Removes the extra border on the sidebar that is producing a pixel shift between light and dark mode. I can't see the need for this border buy maybe @coolcat-creations sees something I am missing and it should remain
|
I have tested this item ✅ successfully on fd8aaf9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161. |
|
The border was added because of the Wish from release management for better contrast between content and sidebar and toolbar and content @LadySolveig |
In case it could be a border only on the right? |
If I added it surrounding the sidebar it was indeed a mistake |
|
I have tested this item ✅ successfully on fd8aaf9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161. |
| @include color-mode(dark) { | ||
| .sidebar-wrapper { | ||
| overflow: hidden; | ||
| border: 1px solid rgba(255, 255, 255, .05); |
There was a problem hiding this comment.
--atum-box-shadow: 1px 0px 0px 0px rgba(255, 255, 255, .05);
Instead of adding as border, a box-shadow should not cause a pixel shift.
Removes the extra border on the sidebar that is producing a pixel shift between light and dark mode.
I can't see the need for this border buy maybe @coolcat-creations sees something I am missing and it should remain
Pull Request for Issue #43159
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed