Skip to content

[5.1] sidebar-wrapper border#43161

Closed
brianteeman wants to merge 1 commit intojoomla:5.1-devfrom
brianteeman:sidebar-wrapper
Closed

[5.1] sidebar-wrapper border#43161
brianteeman wants to merge 1 commit intojoomla:5.1-devfrom
brianteeman:sidebar-wrapper

Conversation

@brianteeman
Copy link
Contributor

Removes the extra border on the sidebar that is producing a pixel shift between light and dark mode.

I can't see the need for this border buy maybe @coolcat-creations sees something I am missing and it should remain

Pull Request for Issue #43159

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Removes the extra border on the sidebar that is producing a pixel shift between light and dark mode.

I can't see the need for this border buy maybe @coolcat-creations sees something I am missing and it should remain
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Mar 26, 2024
@Razzo1987
Copy link
Contributor

Razzo1987 commented Mar 26, 2024

I have tested this item ✅ successfully on fd8aaf9

now the menu items do not move horizontally when changing from light to dark theme.
They move vertically, but I think it is related to issue fixed with #43138


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161.

@coolcat-creations
Copy link
Contributor

The border was added because of the Wish from release management for better contrast between content and sidebar and toolbar and content @LadySolveig

@Razzo1987
Copy link
Contributor

The border was added because of the Wish from release management for better contrast between content and sidebar and toolbar and content @LadySolveig

In case it could be a border only on the right?

@coolcat-creations
Copy link
Contributor

The border was added because of the Wish from release management for better contrast between content and sidebar and toolbar and content @LadySolveig

In case it could be a border only on the right?

If I added it surrounding the sidebar it was indeed a mistake

@Quy
Copy link
Contributor

Quy commented Mar 27, 2024

I have tested this item ✅ successfully on fd8aaf9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161.

@Quy
Copy link
Contributor

Quy commented Mar 27, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@brianteeman brianteeman closed this Apr 3, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 3, 2024
@brianteeman brianteeman deleted the sidebar-wrapper branch April 3, 2024 07:30
@include color-mode(dark) {
.sidebar-wrapper {
overflow: hidden;
border: 1px solid rgba(255, 255, 255, .05);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

      --atum-box-shadow: 1px 0px 0px 0px rgba(255, 255, 255, .05);

Instead of adding as border, a box-shadow should not cause a pixel shift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants