[5.4] Remove sidebar border in dark mode#45469
Closed
C-Lodder wants to merge 1 commit intojoomla:5.4-devfrom
Closed
[5.4] Remove sidebar border in dark mode#45469C-Lodder wants to merge 1 commit intojoomla:5.4-devfrom
C-Lodder wants to merge 1 commit intojoomla:5.4-devfrom
Conversation
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
I have tested this item ✅ successfully on e35a86a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45469. |
Contributor
|
previous attempt did the same thing and was rejected #43161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When switching between light and dark mode in the backend template, you'll notice the sidebar contents moves by about 2px.
This is because a border is being applied only in dark mode.
This PR removes the border in dark mode as it's barely visible anyway.
Testing Instructions
npm run build:css.Actual result BEFORE applying this Pull Request
Sidebar content layout shift
Expected result AFTER applying this Pull Request
No layout shift