Skip to content

[5.1] pixel shift from dark to light#43138

Merged
LadySolveig merged 1 commit intojoomla:5.1-devfrom
brianteeman:patch-6
Mar 27, 2024
Merged

[5.1] pixel shift from dark to light#43138
LadySolveig merged 1 commit intojoomla:5.1-devfrom
brianteeman:patch-6

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #43029 .

Summary of Changes

remove additional border on header buttons in dark mode
this prevents the layout shift between light/dark templates

Actual result BEFORE applying this Pull Request

beforeshift

Expected result AFTER applying this Pull Request

shift

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Mar 24, 2024

Thanks for the fix everyone (hug).

@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

I have tested this item ✅ successfully on 8e7b8c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 8e7b8c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138.

@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 24, 2024
@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 24, 2024
@Razzo1987 Razzo1987 mentioned this pull request Mar 26, 2024
4 tasks
@LadySolveig LadySolveig merged commit e25299b into joomla:5.1-dev Mar 27, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@LadySolveig
Copy link
Contributor

Thank you @brianteeman and also for testing @Quy @viocassel

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the patch-6 branch March 27, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants