Skip to content

Comments

Updates the dependencies#41538

Merged
laoneo merged 12 commits intojoomla:4.4-devfrom
Digital-Peak:deps
Sep 4, 2023
Merged

Updates the dependencies#41538
laoneo merged 12 commits intojoomla:4.4-devfrom
Digital-Peak:deps

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Sep 1, 2023

Updates the dependencies including the lift to cypress 13 as there was a vulnerability reported in cypress 12.

image

@joomla-cms-bot joomla-cms-bot added Composer Dependency Changed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev labels Sep 1, 2023
@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on b12d4eb

This is not correct.
You must do a full npm and composer install when you do these updates as there are files that might get updated by other scripts when dependencies are updated.

For example tinmyce and codemirror where the version number in the plugin is updated


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41538.

@laoneo
Copy link
Member Author

laoneo commented Sep 1, 2023

Not sure why this is not part of the update command @dgrammatiko ?

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Sep 1, 2023

rpm run update:

"update": "node build/build.js --copy-assets && node build/build.js --build-pages && node build/build.js --compile-js && node build/build.js --compile-css && node build/build.js --compile-bs && set NODE_ENV=PRODUCTION && node build/build.js --com-media",
?

Edit: you need to manually bump the package.json versions and then run the command above IIRC

@laoneo
Copy link
Member Author

laoneo commented Sep 1, 2023

Thanks, fixed it

@Hackwar
Copy link
Member

Hackwar commented Sep 1, 2023

Something is wrong here. The vue package is a hard dependency, but I can't find it as a full package in the package-lock.json.

@Hackwar
Copy link
Member

Hackwar commented Sep 1, 2023

In any case, since this PR already contains those updates, I'm closing #41451 and #41455.

@laoneo
Copy link
Member Author

laoneo commented Sep 1, 2023

There are over 7'000 removald un the package lock file in this pr. Not sure if this has something to do with a never npm version since I did it last time.

@brianteeman brianteeman mentioned this pull request Sep 1, 2023
@brianteeman
Copy link
Contributor

I tried and built #41545 for comparison

@laoneo
Copy link
Member Author

laoneo commented Sep 4, 2023

@brianteeman which npm version did you use?

@laoneo
Copy link
Member Author

laoneo commented Sep 4, 2023

I'v just did a fresh install of the package from drone and all works. Nothing indicates that there is an error in an asset. Also the system tests are running through, when they do not hit the timeout.

@brianteeman
Copy link
Contributor

@brianteeman which npm version did you use?

8.19.2

@dgrammatiko
Copy link
Contributor

@laoneo could you restore the indentation to 2 spaces instead of 4 for the package.json and the lock file?

@laoneo
Copy link
Member Author

laoneo commented Sep 4, 2023

Reverted the last commit

@laoneo
Copy link
Member Author

laoneo commented Sep 4, 2023

@brianteeman which npm version did you use?

8.19.2

That might be the issue as I'm on 9.6.7.

@laoneo
Copy link
Member Author

laoneo commented Sep 4, 2023

@dgrammatiko gets the same effect, so we are fine with this pr here as I do mainly the updates
image

@dgrammatiko
Copy link
Contributor

FWIW it's time to push node/npm as 16 that we are currently have as minimum goes EOL in few weeks. It's on my todo list

@laoneo
Copy link
Member Author

laoneo commented Sep 4, 2023

But I would do it on 5.0 then only.

@laoneo laoneo merged commit e481884 into joomla:4.4-dev Sep 4, 2023
@laoneo laoneo added this to the Joomla! 4.4.0 milestone Sep 4, 2023
HLeithner pushed a commit that referenced this pull request Sep 4, 2023
* fix calendar positioning (#41477)

* Update joomla-field-media.w-c.es6.js (#41361)

* Fixing md5 Deprecation in document.php (#39880)

* modal field check for danger alert (#39173)

* fix (#41138)

* [4.x] Cassiopeia Install SQL (#37389)

* Fix/showon (#37451)

* Bugfix for Issue #38599 - Smart Search indexing macros from articles (#38998)

* [4,3] joomla alert icons (#39312)

* Update StyleModel.php (#40665)

* Update Query.php (#40687)

* remove hitcount variable from uri after voting (#41474)

* Fix deprecated message in categories when extension is empty (#40604)

* Re-add minus to allowed filenames in com_templates (#41369)

* Invalid delete of all content articles from smart search index (#41288)

* [4][cli] schema update check (#40468)

* Tags: Don't put NULL into trim() (#41509)

Co-authored-by: Quy <quy@nomonkeybiz.com>

* [4] Add multilanguage filter taxonomy rows in com_finder advanced filters (#41470)

* Fix taxonomy filter options

* refactor rest of query to prepared statements

---------

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Check if the pre update check box actually exists (#41467)

* Allow onValidateContact plugin to show error message (#37540)

* [4.4] Backward compatibility handling for plugins that setting the result directly (#41525)

* Backward compatibility handling for plugins that setting the result directly.

* Update libraries/src/Event/AbstractImmutableEvent.php

Co-authored-by: Brian Teeman <brian@teeman.net>

---------

* Tests for com_privacy consent on user site (#41529)

* Tests for com_privacy consent on user site

* Allow ability to enable extension in tests to prevent errors

* remove paramater not needed

* Added fixes to stop  errors in drone build

* Added fixes to stop  errors in drone build

* Added fixes to stop  errors in drone build

* [4.4] system test for com_installer (#41483)

* system test for com_installer

* cs

* Missing System Tests in #41362 (#41479)

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

added spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

removed tabs

* Update Categories.cy.js

Removed tabs

* Update Categories.cy.js

Removed tabs

* Update Categories.cy.js

Removed tabs

* Update Language.php (#41353)

* Filter for special characters that fail sending test mail (#41469)

* Backporting event changes (#41484)

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

* api tests for endpoints for com_privacy consent (#41544)

* Show the plugin name in the update screen (#41537)

* Show the plugin name in the update screen

* cs

---------

* Replace the special characters in site name for mail templates (#41582)

* Updates the dependencies (#41538)

* Updating dependencies

* Major update cypress

* Thanks for the reminder @brianteeman

* Composer

* weekend updates

* Update dependencies

* Update incompatible HTML file

---------

Co-authored-by: Magnus Singer <magnussinger@icloud.com>
Co-authored-by: Dimitris Grammatikogiannis <d.grammatiko@gmail.com>
Co-authored-by: Crystal Dionysopoulos <9141288+crystalenka@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Denitz <197527+Denitz@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: toroworx <toroworx@users.noreply.github.com>
Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com>
Co-authored-by: Jonathan Brain <3941269+BrainforgeUK@users.noreply.github.com>
Co-authored-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com>
Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de>
Co-authored-by: Manuel Huber <ManuelHu@users.noreply.github.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Hannes Papenberg <info@joomlager.de>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: beefcakefu <103491197+beefcakefu@users.noreply.github.com>
Co-authored-by: Fedir Zinchuk <getthesite@gmail.com>
Co-authored-by: andyforrest <46865032+andyforrest@users.noreply.github.com>
@laoneo laoneo deleted the deps branch September 8, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Composer Dependency Changed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants