Skip to content

Comments

Filter for special characters that fail sending test mail#41469

Merged
obuisard merged 5 commits intojoomla:4.3-devfrom
magnussinger:i41061
Sep 1, 2023
Merged

Filter for special characters that fail sending test mail#41469
obuisard merged 5 commits intojoomla:4.3-devfrom
magnussinger:i41061

Conversation

@magnussinger
Copy link
Contributor

Pull Request for Issue #41061.

Summary of Changes

When trying to send a test mail from the backend, it now filters the site name so the sending does succeed.

Testing Instructions

Enter a site name containing "@" and/or "|" and try to send a test mail

Actual result BEFORE applying this Pull Request

The mail could not be sent

Expected result AFTER applying this Pull Request

The mail can be sent

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@formfranska
Copy link

I have tested this item ✅ successfully on 90f94a6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41469.

@brianteeman
Copy link
Contributor

This should contain some comments in the code so that in the future someone will know why the preg_filter has been added

@MacJoom
Copy link
Contributor

MacJoom commented Aug 26, 2023

I have tested this item ✅ successfully on 90f94a6

on 4.3.4 - the patch works however i could not reproduce the issue on my system: My sitename is Test|PR@Infotech
before:
Test mail from Test|PR@Infotech (Subject works, all send methods)
after:
Test mail from TestPRInfotech ( | and @ are stripped in the subject for all send methods)

but anyway it just in the testmail...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41469.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41469.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2023
@magnussinger
Copy link
Contributor Author

This should contain some comments in the code so that in the future someone will know why the preg_filter has been added

@brianteeman I added a comment to the file

@obuisard obuisard added this to the Joomla! 4.3.5 milestone Sep 1, 2023
@obuisard obuisard merged commit 3bb67d5 into joomla:4.3-dev Sep 1, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 1, 2023
@obuisard
Copy link
Contributor

obuisard commented Sep 1, 2023

Thank you Magnus @magnussinger for the PR!

@laoneo
Copy link
Member

laoneo commented Sep 4, 2023

This here breaks the system tests on 4.4 as the site name is always null when none of these special characters are in the string. You can test it here https://onlinephp.io?s=s7EvyCjg5SpLLIpPKc0t0CgoSk2PT8vMKUkt0ohW13fQV9dRUNePqdFXjwUyQJyQ1OISIK1rqKlpDQA%2C&v=8.2.10

HLeithner pushed a commit that referenced this pull request Sep 4, 2023
* fix calendar positioning (#41477)

* Update joomla-field-media.w-c.es6.js (#41361)

* Fixing md5 Deprecation in document.php (#39880)

* modal field check for danger alert (#39173)

* fix (#41138)

* [4.x] Cassiopeia Install SQL (#37389)

* Fix/showon (#37451)

* Bugfix for Issue #38599 - Smart Search indexing macros from articles (#38998)

* [4,3] joomla alert icons (#39312)

* Update StyleModel.php (#40665)

* Update Query.php (#40687)

* remove hitcount variable from uri after voting (#41474)

* Fix deprecated message in categories when extension is empty (#40604)

* Re-add minus to allowed filenames in com_templates (#41369)

* Invalid delete of all content articles from smart search index (#41288)

* [4][cli] schema update check (#40468)

* Tags: Don't put NULL into trim() (#41509)

Co-authored-by: Quy <quy@nomonkeybiz.com>

* [4] Add multilanguage filter taxonomy rows in com_finder advanced filters (#41470)

* Fix taxonomy filter options

* refactor rest of query to prepared statements

---------

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Check if the pre update check box actually exists (#41467)

* Allow onValidateContact plugin to show error message (#37540)

* [4.4] Backward compatibility handling for plugins that setting the result directly (#41525)

* Backward compatibility handling for plugins that setting the result directly.

* Update libraries/src/Event/AbstractImmutableEvent.php

Co-authored-by: Brian Teeman <brian@teeman.net>

---------

* Tests for com_privacy consent on user site (#41529)

* Tests for com_privacy consent on user site

* Allow ability to enable extension in tests to prevent errors

* remove paramater not needed

* Added fixes to stop  errors in drone build

* Added fixes to stop  errors in drone build

* Added fixes to stop  errors in drone build

* [4.4] system test for com_installer (#41483)

* system test for com_installer

* cs

* Missing System Tests in #41362 (#41479)

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

* Update Categories.cy.js

added spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

Missing spaces and semicolons

* Update Categories.cy.js

removed tabs

* Update Categories.cy.js

Removed tabs

* Update Categories.cy.js

Removed tabs

* Update Categories.cy.js

Removed tabs

* Update Language.php (#41353)

* Filter for special characters that fail sending test mail (#41469)

* Backporting event changes (#41484)

Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

* api tests for endpoints for com_privacy consent (#41544)

* Show the plugin name in the update screen (#41537)

* Show the plugin name in the update screen

* cs

---------

* Replace the special characters in site name for mail templates (#41582)

* Updates the dependencies (#41538)

* Updating dependencies

* Major update cypress

* Thanks for the reminder @brianteeman

* Composer

* weekend updates

* Update dependencies

* Update incompatible HTML file

---------

Co-authored-by: Magnus Singer <magnussinger@icloud.com>
Co-authored-by: Dimitris Grammatikogiannis <d.grammatiko@gmail.com>
Co-authored-by: Crystal Dionysopoulos <9141288+crystalenka@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Denitz <197527+Denitz@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: toroworx <toroworx@users.noreply.github.com>
Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com>
Co-authored-by: Jonathan Brain <3941269+BrainforgeUK@users.noreply.github.com>
Co-authored-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com>
Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de>
Co-authored-by: Manuel Huber <ManuelHu@users.noreply.github.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Hannes Papenberg <info@joomlager.de>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: beefcakefu <103491197+beefcakefu@users.noreply.github.com>
Co-authored-by: Fedir Zinchuk <getthesite@gmail.com>
Co-authored-by: andyforrest <46865032+andyforrest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants