Fix/showon by toroworx · Pull Request #37451 · joomla/joomla-cms

toroworx · 2022-04-01T16:04:37Z

Pull Request for Issue # .
#37299

Summary of Changes

Fixed showon issue for nested options as described above.

Testing Instructions

#37300 (comment)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

none

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

richard67 · 2022-06-27T17:31:30Z

I've allowed myself to fix the merge conflict after the rebase.

robinclapp · 2023-08-26T16:05:01Z

I have tested this item ✅ successfully on fec38be

Note, that the other issue where status gets stuck when pinned inside com_banner edit

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37451.}

blanderson22 · 2023-08-26T16:05:11Z

I have tested this item ✅ successfully on fec38be

Note, that the other issue mentioned on GitHub, where status gets stuck when pinned inside com_banner edit, still exists.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37451.}

richard67 · 2023-08-26T16:07:23Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37451.}

obuisard · 2023-08-29T00:19:34Z

Thank you @toroworx for the PR!

toroworx · 2023-08-29T15:11:53Z

You're most welcome! Thanks for testing and merging :-) @richard67 @robinclapp @blanderson22 @obuisard

@brianteeman

* fix calendar positioning (#41477) * Update joomla-field-media.w-c.es6.js (#41361) * Fixing md5 Deprecation in document.php (#39880) * modal field check for danger alert (#39173) * fix (#41138) * [4.x] Cassiopeia Install SQL (#37389) * Fix/showon (#37451) * Bugfix for Issue #38599 - Smart Search indexing macros from articles (#38998) * [4,3] joomla alert icons (#39312) * Update StyleModel.php (#40665) * Update Query.php (#40687) * remove hitcount variable from uri after voting (#41474) * Fix deprecated message in categories when extension is empty (#40604) * Re-add minus to allowed filenames in com_templates (#41369) * Invalid delete of all content articles from smart search index (#41288) * [4][cli] schema update check (#40468) * Tags: Don't put NULL into trim() (#41509) Co-authored-by: Quy <quy@nomonkeybiz.com> * [4] Add multilanguage filter taxonomy rows in com_finder advanced filters (#41470) * Fix taxonomy filter options * refactor rest of query to prepared statements --------- Co-authored-by: Quy <quy@nomonkeybiz.com> * Check if the pre update check box actually exists (#41467) * Allow onValidateContact plugin to show error message (#37540) * [4.4] Backward compatibility handling for plugins that setting the result directly (#41525) * Backward compatibility handling for plugins that setting the result directly. * Update libraries/src/Event/AbstractImmutableEvent.php Co-authored-by: Brian Teeman <brian@teeman.net> --------- * Tests for com_privacy consent on user site (#41529) * Tests for com_privacy consent on user site * Allow ability to enable extension in tests to prevent errors * remove paramater not needed * Added fixes to stop errors in drone build * Added fixes to stop errors in drone build * Added fixes to stop errors in drone build * [4.4] system test for com_installer (#41483) * system test for com_installer * cs * Missing System Tests in #41362 (#41479) * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js * Update Categories.cy.js added spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js Missing spaces and semicolons * Update Categories.cy.js removed tabs * Update Categories.cy.js Removed tabs * Update Categories.cy.js Removed tabs * Update Categories.cy.js Removed tabs * Update Language.php (#41353) * Filter for special characters that fail sending test mail (#41469) * Backporting event changes (#41484) Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * api tests for endpoints for com_privacy consent (#41544) * Show the plugin name in the update screen (#41537) * Show the plugin name in the update screen * cs --------- * Replace the special characters in site name for mail templates (#41582) * Updates the dependencies (#41538) * Updating dependencies * Major update cypress * Thanks for the reminder @brianteeman * Composer * weekend updates * Update dependencies * Update incompatible HTML file --------- Co-authored-by: Magnus Singer <magnussinger@icloud.com> Co-authored-by: Dimitris Grammatikogiannis <d.grammatiko@gmail.com> Co-authored-by: Crystal Dionysopoulos <9141288+crystalenka@users.noreply.github.com> Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> Co-authored-by: Denitz <197527+Denitz@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: toroworx <toroworx@users.noreply.github.com> Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com> Co-authored-by: Jonathan Brain <3941269+BrainforgeUK@users.noreply.github.com> Co-authored-by: Olivier Buisard <olivier.buisard@simplifyyourweb.com> Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de> Co-authored-by: Manuel Huber <ManuelHu@users.noreply.github.com> Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com> Co-authored-by: Hannes Papenberg <info@joomlager.de> Co-authored-by: Quy <quy@nomonkeybiz.com> Co-authored-by: David Jardin <d.jardin@djumla.de> Co-authored-by: beefcakefu <103491197+beefcakefu@users.noreply.github.com> Co-authored-by: Fedir Zinchuk <getthesite@gmail.com> Co-authored-by: andyforrest <46865032+andyforrest@users.noreply.github.com>

dgrammatiko and others added 16 commits March 17, 2022 00:57

list-show-on

c399fe8

Update ListField.php

cb41ce0

Update libraries/src/Form/Field/ListField.php

ac8bed2

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

Update list.php

6a7684e

Update ListField.php

93b2068

Update list.php

3f44437

Update ListField.php

723f805

Update FormField.php

284aa6c

Update ListField.php

113a68f

Update ListField.php

b761cf4

Tiny perf

281b1c9

Update libraries/src/Form/FormField.php

32997d5

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

Merge branch '4.1-dev' into patch-17

0677579

Merge branch '4.1-dev' into patch-17

7b7a58d

Merge branch '4.1-dev' into patch-17

79376e3

Fix showon for nested option

d428b1f

joomla-cms-bot added the PR-4.1-dev label Apr 1, 2022

This was referenced Apr 1, 2022

[4.1] Form list with showon attributes should load the show on script #37300

Closed

Showon not working when used within list option #37299

Closed

richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022

Quy added Conflicting Files labels Jun 18, 2022

HLeithner changed the base branch from 4.1-dev to 4.2-dev June 27, 2022 13:05

Merge branch '4.2-dev' into fix/showon

eb49473

joomla-cms-bot added the PR-4.2-dev label Jun 27, 2022

richard67 removed Conflicting Files PBF Pizza, Bugs and Fun PR-4.1-dev labels Jun 27, 2022

Phase 1 convert BRANCH to PSR-12

198cc58

joomla-bot added the psr12 label Jun 27, 2022

HLeithner removed the psr12 label Oct 23, 2022

Hackwar added the Small A PR which only has a small change label Feb 26, 2023

Merge branch '4.2-dev' into fix/showon

fec38be

Quy changed the base branch from 4.2-dev to 4.3-dev March 24, 2023 01:40

Quy added PR-4.3-dev and removed PR-4.2-dev labels Mar 24, 2023

Hackwar added the bug label Apr 6, 2023

Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023

richard67 added PR-4.2-dev and removed PBF Pizza, Bugs and Fun bug PR-4.3-dev labels Aug 26, 2023

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2023

richard67 added bug PR-4.3-dev PBF Pizza, Bugs and Fun and removed PR-4.2-dev labels Aug 26, 2023

richard67 and others added 3 commits August 26, 2023 18:08

Merge branch '4.3-dev' into fix/showon

c9cb6cb

Fix PHPCS failing in drone

eb876a5

Merge branch '4.3-dev' into fix/showon

cbe9361

obuisard added this to the Joomla! 4.3.5 milestone Aug 29, 2023

obuisard merged commit d6e533c into joomla:4.3-dev Aug 29, 2023

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Fix/showon#37451

Fix/showon#37451
obuisard merged 24 commits intojoomla:4.3-devfrom
toroworx:fix/showon

toroworx commented Apr 1, 2022 •

edited

Loading

Uh oh!

richard67 commented Jun 27, 2022

Uh oh!

robinclapp commented Aug 26, 2023

Uh oh!

blanderson22 commented Aug 26, 2023

Uh oh!

richard67 commented Aug 26, 2023

Uh oh!

obuisard commented Aug 29, 2023

Uh oh!

toroworx commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Comments

Conversation

toroworx commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Uh oh!

richard67 commented Jun 27, 2022

Uh oh!

robinclapp commented Aug 26, 2023

Uh oh!

blanderson22 commented Aug 26, 2023

Uh oh!

richard67 commented Aug 26, 2023

Uh oh!

obuisard commented Aug 29, 2023

Uh oh!

toroworx commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

toroworx commented Apr 1, 2022 •

edited

Loading