[5.0] [RFC] Fix update path from previous 5.0.0 alphas

[richard67]

Pull Request for Issue # .

Summary of Changes

This pull request (PR) fixes the currently broken update path from previous 5.0 alpha versions to the upcoming alpha 4 by fixing points mentioned in the description of PR #41393 :

• Add file '/plugins/schemaorg/blogposting/src/Extension/Blogposting.php' from PR [5.0] schema.org cleanup #41260 to the list of files to be renamed on update in file "administrator/components/com_admin/script.php".
• Add uninstallation of obsolete system plugin due to PR [5.0] Move the compatibility plugin from system to behaviour folder #41276 and migration of the obsolete plugin's enabled status and parameters to the new behaviour plugin's parameters on update to file "administrator/components/com_admin/script.php", and add file '/media/plg_system_compat/es5.asset.json' to the deleted files list in in file "administrator/components/com_admin/script.php" because that file is not removed when the plugin is uninstalled due to an incomplete manifest xml of that plugin.

In addition, this PR adds the necessary exceptions to the "build/deleted_file_check.php" script so that the files of the obsolete system plugin which will be removed by the installer when uninstalling the plugin are not added to the lists of deleted files and folders generated by the script.

Finally, this PR here includes also the changes from PR #41393 for easier testing.

As described in that PR, the 2 mentioned points result from deliberate decisions of the release managers, so this PR here is just an offer in case if they decide to change their mind.

Testing Instructions

Test 1 update from 5.0.0-alpha3

1. Install a 5.0.0-alpha3.
2. Enable the "System - Backward Compatibility" plugin and change some of its parameters.
3. Switch error reporting to maximum in Global Configuration.
4. Update to the patched update package or custom update URL created by drone for this PR.
   Result: The update succeeds.
5. Check if the "System - Backward Compatibility" plugin has been properly uninstalled.
   Result: The plugin has been uninstalled.
6. Check the enabled status and parameters of the new "Behaviour - Backward Compatibility" plugin.
   Result: The plugin is enabled, the parameters are equal to those set in step 2 for the old system plugin.
7. Repeat steps 1 and 3 to 6 but not step 2 so that the old plugin is disabled on update.
   Result: The new plugin "Behaviour - Backward Compatibility" is disabled.
8. Check if the files and folders of the obsolete "System - Backward Compatibility" plugin have been deleted.
   Result: All files and folders belonging to that plugin have been deleted.
9. Check if file '/plugins/schemaorg/blogposting/src/Extension/Blogposting.php' has been renamed to '/plugins/schemaorg/blogposting/src/Extension/BlogPosting.php'.
   Result: The file has been renamed.

Test 2 for the changes in "build/deleted_file_check.php"

1. On a clean, current 5.0-dev branch (no need for having run composer or npm and no need for a Joomla installation), download the following 2 full installation zip packages and save them in the "tmp" folder:

• 5.0.0-alpha3 https://github.com/joomla/joomla-cms/releases/download/5.0.0-alpha3/Joomla_5.0.0-alpha3-Alpha-Full_Package.zip
• Latest 5.0 nightly build https://developer.joomla.org/nightlies/Joomla_5.0.0-alpha4-dev-Development-Full_Package.zip

2. Unpack the 2 previously downloaded zip packages into 2 separate folders in the "tmp" folder, e.g. folders "Joomla_5.0.0-alpha3-Alpha-Full_Package" and "Joomla_5.0.0-alpha4-dev-Development-Update_Package".
3. In a command windows in the directory with your git clone and the branch from step 1, run the following command to check the two folders from the previous step for deleted files and folders (on Windows you have to use backslashes \ instead of slashes / for the paths):

php ./build/deleted_file_check.php --from=./tmp/Joomla_5.0.0-alpha3-Alpha-Full_Package --to=./tmp/Joomla_5.0.0-alpha4-dev-Development-Update_Package

4. Check the 2 created text files ./build/deleted_files.txt and ./build/deleted_folders.txt.
   Result: See section "Actual result BEFORE applying this Pull Request" below.
5. Save the 2 text files from step 4 for later comparison.
6. Apply the changes from this PR.
7. Repeat steps 3 and 4 and compare the 2 text files with those saved in step 5.
   Result: See section "Expected result AFTER applying this Pull Request" below.

Actual result BEFORE applying this Pull Request

Test 1 update from 5.0.0-alpha3

The files and folders of the obsolete "System - Backward Compatibility" plugin have not been removed.

The plugin has not been uninstalled.

The new "Behaviour - Backward Compatibility" plugin is enabled with the default options.

File '/plugins/schemaorg/blogposting/src/Extension/Blogposting.php' has not been renamed to '/plugins/schemaorg/blogposting/src/Extension/BlogPosting.php'. This will cause schema.org for blog posts not working on Windows or Mac hosts after updates from previous 5.0 alpha versions.

Test 2 for the changes in "build/deleted_file_check.php"

All files and folders belonging to the old "System - Backward Compatibility" are in the lists of deleted files and folders.

Expected result AFTER applying this Pull Request

Test 1 update from 5.0.0-alpha3

The files and folders of the obsolete "System - Backward Compatibility" plugin have been removed.

The plugin has been uninstalled.

The new "Behaviour - Backward Compatibility" plugin is disabled when the old plugin was disabled before the update, and it is enabled and has inherited the old plugin's parameters when the old plugin was enabled before the update.

File '/plugins/schemaorg/blogposting/src/Extension/Blogposting.php' has been renamed to '/plugins/schemaorg/blogposting/src/Extension/BlogPosting.php'.

Test 2 for the changes in "build/deleted_file_check.php"

Only folder "/media/plg_system_compat" and files in that folder are in the list of deleted files, no other files or folders of the obsolete "System - Backward Compatibility" plugin are in the lists.

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed

• No documentation changes for manual.joomla.org needed

[HLeithner]

thanks